Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1003837ybh; Tue, 21 Jul 2020 13:16:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy7z6CWm+T9OmSKSEKr4MvGpFkWryb9DWAsNPIsApbuJu7lqzmAmB90ONmbOsMm0LiNrxUF X-Received: by 2002:a50:af45:: with SMTP id g63mr28658625edd.52.1595362592039; Tue, 21 Jul 2020 13:16:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595362592; cv=none; d=google.com; s=arc-20160816; b=vMogqOawqlpF3dUnMoGBWXxRHPRx4wXnSWzIFDOKceHHGg7FzOvuE8RcPt7GZFCX3G tSywSJOdx6blGwXzVGpGN7Poixv947XDcyCQ1hU10WJekgBXS/iPPwdVk8z+mRQTdH2e st4JtkmlXBKIvZpBT92Etzbm8oXa8xLq41gmunc5t8UCVWmJ2HeVfpVMqjeWHSg1Q2NX C0j33sXpg45101K510wt2VXPQWFY3FMu7gfDvN+RE0pOLd1yVUI/45gAMkRtDg6cLL8M xpmgpDd8aST/SJDsiOy9sXfxh7NGUwpjJ/Fk6xjOMhs//4Zk7KCSwazqI9RI+p/TYKMU Rthg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=2uPptlWLxysnY2DN8cVpiLHvydVOmdRUrC7/ffuXVEg=; b=NvMiucUAOI617QKwzaSkZYoiStGoUerIiXuOC/YwTsIqFAMazgXL+TCAbj1Wcf5Uh3 nU2MAaC++pqfthIvYSmuPk0YZgrW0ZUjM9Oh1n9Q0hdmNiqKaC2D3iVF7Gb8kM5U/SRg MJq3wE1xlnyywW/ulF33BQxlX7MEOWHFGYYovPezNk5WTpPTV1lR0gOL3gZVgU1lWUHn Ftwk+pSYbVBhTPMY4uWO63ubDHeCG8U2P1udGOv+BHiKldYDGlTkrkj5MXaufqmSrhbf J8T+SFDxBReOEkTjEjTRefHO4gST1Tnfm7bSwhCnJs8sm4sISjI6Idq3kZroNe2V2oCk dN4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gx2si12631585ejb.706.2020.07.21.13.16.05; Tue, 21 Jul 2020 13:16:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ispras.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729266AbgGUUQC (ORCPT + 99 others); Tue, 21 Jul 2020 16:16:02 -0400 Received: from mail.ispras.ru ([83.149.199.84]:54136 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbgGUUQB (ORCPT ); Tue, 21 Jul 2020 16:16:01 -0400 Received: from hellwig.intra.ispras.ru (unknown [10.10.2.182]) by mail.ispras.ru (Postfix) with ESMTPS id 39A094089EF1; Tue, 21 Jul 2020 20:15:59 +0000 (UTC) From: Evgeny Novikov To: Felipe Balbi Cc: Evgeny Novikov , Greg Kroah-Hartman , Benjamin Herrenschmidt , Kees Cook , Arnd Bergmann , Corentin Labbe , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] usb: gadget: net2280: fix memory leak on probe error handling paths Date: Tue, 21 Jul 2020 23:15:58 +0300 Message-Id: <20200721201558.20069-1-novikov@ispras.ru> X-Mailer: git-send-email 2.16.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Driver does not release memory for device on error handling paths in net2280_probe() when gadget_release() is not registered yet. The patch fixes the bug like in other similar drivers. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Evgeny Novikov --- drivers/usb/gadget/udc/net2280.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/net2280.c b/drivers/usb/gadget/udc/net2280.c index 5eff85eeaa5a..d5fe071b2db2 100644 --- a/drivers/usb/gadget/udc/net2280.c +++ b/drivers/usb/gadget/udc/net2280.c @@ -3781,8 +3781,10 @@ static int net2280_probe(struct pci_dev *pdev, const struct pci_device_id *id) return 0; done: - if (dev) + if (dev) { net2280_remove(pdev); + kfree(dev); + } return retval; } -- 2.16.4