Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1049712ybh; Tue, 21 Jul 2020 14:29:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyKbK0F6+INVrnB3OudN3RpgHx2O0GVFF7GI7D9MSF0uudmjC6T+rOCe11eTG3p7RPu1M1n X-Received: by 2002:aa7:c4d8:: with SMTP id p24mr27018403edr.323.1595366990098; Tue, 21 Jul 2020 14:29:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595366990; cv=none; d=google.com; s=arc-20160816; b=m7ZcE+sLir/MpOTYJxYUqQFJSPFjB5nGHreT3RuJ1f1Iympqz3nbHmC3SnqRkOzH6I 5AMLNzU+zlwIFZPDycyO8tNGOcJEmHfpVgO8pmfYWyumEXNGn6a+xVcFwmWWOEBVA5wc j/AyCTYrL25GhhVhXLaaaCPCSV3j1BbtRiP75pdXwLprXD85kM58yM0rmvTcK4WtuUV3 qEYSFXc0lREcx72jpKiXUd7/EEq2KvCOYDuvqKUlunq8ABNMshbDaE+CeqY/a+LQjHAE ozgzqEpQvWhf6WZRa1UaND0rCjNitK9TBEPU6KGitBOhXVSyXWN6rrbz6XsdWD44iVWO qReQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date; bh=sDHTp32+xNw2sNBsjLmOgVHrprTD/LRUCIy8BQRXc7I=; b=uj+WWXKsBwObkgqVTmR1BvTdqIKxY/S82URW96AlDUaH8Al8AvAa3WPeu+pkThYZ18 FbnPzq/ILyRrAuySdEHa+GaUXM9He4xlwLOjsncMr0Ih2YoSEttgbpNAa9vC9wFD9bW1 vaC0jQ5OQF7fkRJ2WEaHrTBuNKdDZPY29JeIzSMws1+GdlDsWUJcvDcaRyA8HE+SDsdW 66rnH1Y0VS8UjOQ8MMv6cbXqzD0bOAVpqy64uLa5HK3kG2tCSbVJAtIj6WN56pswmy6u pNXQdtxR6UsdEpMQXBlkmZcsdxxoMMKxPQ0YjJZWo4attY6kVksQM5hqaKoFrZPK9LRQ e01w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w12si13149372eji.586.2020.07.21.14.29.26; Tue, 21 Jul 2020 14:29:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731046AbgGUV2v (ORCPT + 99 others); Tue, 21 Jul 2020 17:28:51 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:31816 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726658AbgGUV2u (ORCPT ); Tue, 21 Jul 2020 17:28:50 -0400 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06LL2wsa152507; Tue, 21 Jul 2020 17:28:24 -0400 Received: from ppma03fra.de.ibm.com (6b.4a.5195.ip4.static.sl-reverse.com [149.81.74.107]) by mx0b-001b2d01.pphosted.com with ESMTP id 32e1vv3xnm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jul 2020 17:28:24 -0400 Received: from pps.filterd (ppma03fra.de.ibm.com [127.0.0.1]) by ppma03fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 06LLA6KI024505; Tue, 21 Jul 2020 21:28:22 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma03fra.de.ibm.com with ESMTP id 32brq826kx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jul 2020 21:28:22 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 06LLSJ7230146928 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jul 2020 21:28:19 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5257E11C050; Tue, 21 Jul 2020 21:28:19 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EA3AB11C052; Tue, 21 Jul 2020 21:28:16 +0000 (GMT) Received: from oc0525413822.ibm.com (unknown [9.163.39.1]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 21 Jul 2020 21:28:16 +0000 (GMT) Date: Tue, 21 Jul 2020 14:28:13 -0700 From: Ram Pai To: Laurent Dufour Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org, mpe@ellerman.id.au, paulus@samba.org, sukadev@linux.ibm.com, bauerman@linux.ibm.com, bharata@linux.ibm.com, Paul Mackerras Subject: Re: [PATCH v2 1/2] KVM: PPC: Book3S HV: move kvmppc_svm_page_out up Message-ID: <20200721212813.GF7339@oc0525413822.ibm.com> Reply-To: Ram Pai References: <20200721104202.15727-1-ldufour@linux.ibm.com> <20200721104202.15727-2-ldufour@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200721104202.15727-2-ldufour@linux.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-21_15:2020-07-21,2020-07-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 phishscore=0 spamscore=0 bulkscore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=871 malwarescore=0 clxscore=1011 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007210135 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 12:42:01PM +0200, Laurent Dufour wrote: > kvmppc_svm_page_out() will need to be called by kvmppc_uvmem_drop_pages() > so move it upper in this file. > > Furthermore it will be interesting to call this function when already > holding the kvm->arch.uvmem_lock, so prefix the original function with __ > and remove the locking in it, and introduce a wrapper which call that > function with the lock held. > > There is no functional change. Reviewed-by: Ram Pai > > Cc: Ram Pai > Cc: Bharata B Rao > Cc: Paul Mackerras > Signed-off-by: Laurent Dufour > --- RP