Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 21 Jul 2020 23:47:21 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Clark Wang <xiaoning.wang@nxp.com>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] spi: lpspi: fix kernel warning dump when probe fail
 after calling spi_register
Message-ID: <20200721224721.GA33193@sirena.org.uk>
References: <20200714075251.12777-1-xiaoning.wang@nxp.com>
 <20200714075251.12777-4-xiaoning.wang@nxp.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm"
Content-Disposition: inline
In-Reply-To: <20200714075251.12777-4-xiaoning.wang@nxp.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--EVF5PPMfhYS0aIcm
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Jul 14, 2020 at 03:52:49PM +0800, Clark Wang wrote:
> Calling devm_spi_register_controller() too early will cause problem.
> When probe failed occurs after calling devm_spi_register_controller(),
> the call of spi_controller_put() will trigger the following warning dump.

This doesn't apply against current code, please check and resend.

> [    2.092138] ------------[ cut here ]------------
> [    2.096876] kernfs: can not remove 'uevent', no directory
> [    2.102440] WARNING: CPU: 0 PID: 181 at fs/kernfs/dir.c:1503 kernfs_remove_by_name_ns+0xa0/0xb0
> [    2.111142] Modules linked in:
> [    2.114207] CPU: 0 PID: 181 Comm: kworker/0:7 Not tainted 5.4.24-05024-g775c6e8a738c-dirty #1314


Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

--EVF5PPMfhYS0aIcm
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl8XcHkACgkQJNaLcl1U
h9ABZwf/QAz1ZkBEQ11WvbVv1FhvqZyXhY4kxfUBGqxMBeIkKzTZqZQCusd0T7Ah
47kcDS0t9QQE4haXfLRe7PiGvA16xTmm2px8W+vlQbkxnDIwYmIaBueWiiNXGL3x
tIiV3nicZgAtkdYHC+XZeVTYAgsZCzywC1la/kfSjYTAU0ltKIN+DEtkQu7gbaRL
Wh+0/Cqj8CKFJiNTyXIUiJrvRDmpbCCqUaVwhJxnom0P197kiD4SiJhp3KynaqWM
FQZvkIfFu+U/242IVGKbgOe1grcSKZ1fCdYBwON+F5RWvLy1HdLRNmK6uyEmoLXp
2HUXFj147kxJE/POHBVcdnidhfwwzw==
=XZW9
-----END PGP SIGNATURE-----

--EVF5PPMfhYS0aIcm--