Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 9iLPS2wLjZf/hw4nMZR1HRRL1JOE0iccozZDAmbjdCCDkXeWvapJs+f/gqXp46lB7ra63wF7Tm
 o4mV57Lhd7tg==
IronPort-SDR: EdUSW0Kroy9pLQvPhnmhLmYYOgpMioJiapWH6En2np7t2X2KTiWSzCwIAxA87FRz5khEkSDYCa
 3ohxscb2IZ6Q==
Date:   Tue, 21 Jul 2020 16:46:20 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Tang Yizhou <tangyizhou@huawei.com>
Cc:     linux-mm@kvack.org, linux-next@vger.kernel.org,
        linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH -next] mm/gup.c: Fix the comment of return value for
 populate_vma_page_range()
Message-ID: <20200721234619.GC643353@iweiny-DESK2.sc.intel.com>
References: <20200720034303.29920-1-tangyizhou@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200720034303.29920-1-tangyizhou@huawei.com>
User-Agent: Mutt/1.11.1 (2018-12-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jul 20, 2020 at 11:43:03AM +0800, Tang Yizhou wrote:
> The return value of populate_vma_page_range() is consistent with
> __get_user_pages(), and so is the function comment of return value.
> 
> Signed-off-by: Tang Yizhou <tangyizhou@huawei.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
>  mm/gup.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 2cc5eba44362..a55f1ec712e9 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -1386,7 +1386,8 @@ static __always_inline long __get_user_pages_locked(struct mm_struct *mm,
>   *
>   * This takes care of mlocking the pages too if VM_LOCKED is set.
>   *
> - * return 0 on success, negative error code on error.
> + * Return either number of pages pinned in the vma, or a negative error
> + * code on error.
>   *
>   * vma->vm_mm->mmap_lock must be held.
>   *
> -- 
> 2.17.1
>