Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200714161203.31879-1-yanfei.xu@windriver.com>
 <e3cbdb26-9bfb-55e7-c9a7-deb7f8831754@windriver.com> <20200719165746.GJ2786714@ZenIV.linux.org.uk>
 <021ffaaa-daa4-8d80-c5bd-3a6c816d4703@windriver.com>
In-Reply-To: <021ffaaa-daa4-8d80-c5bd-3a6c816d4703@windriver.com>
From:   Suren Baghdasaryan <surenb@google.com>
Date:   Tue, 21 Jul 2020 17:09:18 -0700
Message-ID: <CAJuCfpHUcnEr1duHDjWTRDhpscE6=FWKvjid1eWiMObYY0bL4A@mail.gmail.com>
Subject: Re: [PATCH] userfaultfd: avoid the duplicated release for userfaultfd_ctx
To:     "Xu, Yanfei" <yanfei.xu@windriver.com>,
        Lokesh Gidra <lokeshgidra@google.com>
Cc:     Al Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Jul 19, 2020 at 6:34 PM Xu, Yanfei <yanfei.xu@windriver.com> wrote:
>
>
>
> On 7/20/20 12:57 AM, Al Viro wrote:
> > On Sun, Jul 19, 2020 at 09:58:34PM +0800, Xu, Yanfei wrote:
> >> ping Al Viro
> >>
> >> Could you please help to review this patch? Thanks a lot.
> >
> > That's -next, right?  As for the patch itself...  Frankly,
> Yes, it's -next.
> > Daniel's patch looks seriously wrong.
> Get it.
>
> Regards,
> Yanfei
> >       * why has O_CLOEXEC been quietly smuggled in?  It's
> > a userland ABI change, for fsck sake...
> >       * the double-put you've spotted
> >       * the whole out: thing - just make it
> >       if (IS_ERR(file)) {
> >               userfaultfd_ctx_put(ctx);
> >               return PTR_ERR(file);
> >       }
> >       and be done with that.
> >

Adding Lokesh to take a look.