Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Pawel Laszczak <pawell@cadence.com>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "colin.king@canonical.com" <colin.king@canonical.com>,
        "jpawar@cadence.com" <jpawar@cadence.com>,
        "ben.dooks@codethink.co.uk" <ben.dooks@codethink.co.uk>,
        "kurahul@cadence.com" <kurahul@cadence.com>,
        "sparmar@cadence.com" <sparmar@cadence.com>
Subject: Re: [PATCH v2 4/9] usb: cdns3: drd: return IRQ_NONE explicitly.
Thread-Topic: [PATCH v2 4/9] usb: cdns3: drd: return IRQ_NONE explicitly.
Thread-Index: AQHWWP1GkjzuLMp17E2g/1js/DaXxakSze2A
Date:   Wed, 22 Jul 2020 00:35:19 +0000
Message-ID: <20200722003509.GC5807@b29397-desktop>
References: <20200713100554.28530-1-pawell@cadence.com>
 <20200713100554.28530-5-pawell@cadence.com>
In-Reply-To: <20200713100554.28530-5-pawell@cadence.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CFFA76D02BD8514F8BE668F8ACDDFA1E@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 741e78ce-815a-42c4-bd1b-08d82dd71c89
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 00:35:19.2096
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PHa1goAKHJFNHmoEn8UIr39QBEpNe+TmdheKQZe3n9UeCGxgAuqVVQrc8lmLNp4gt3IQ/qDkctEwcCEq2adurg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6440
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-07-13 12:05:49, Pawel Laszczak wrote:
> IRQ_NONE can be returned indirect.
>=20
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>

Reviewed-by: Peter Chen <peter.chen@nxp.com>

> ---
>  drivers/usb/cdns3/drd.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
> index 6d2da504ad49..05a9f7d54c46 100644
> --- a/drivers/usb/cdns3/drd.c
> +++ b/drivers/usb/cdns3/drd.c
> @@ -279,12 +279,12 @@ static irqreturn_t cdns3_drd_irq(int irq, void *dat=
a)
>  	u32 reg;
> =20
>  	if (cdns->dr_mode !=3D USB_DR_MODE_OTG)
> -		return ret;
> +		return IRQ_NONE;
> =20
>  	reg =3D readl(&cdns->otg_regs->ivect);
> =20
>  	if (!reg)
> -		return ret;
> +		return IRQ_NONE;
> =20
>  	if (reg & OTGIEN_ID_CHANGE_INT) {
>  		dev_dbg(cdns->dev, "OTG IRQ: new ID: %d\n",
> --=20
> 2.17.1
>=20

--=20

Thanks,
Peter Chen=