Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Pawel Laszczak <pawell@cadence.com>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "colin.king@canonical.com" <colin.king@canonical.com>,
        "jpawar@cadence.com" <jpawar@cadence.com>,
        "ben.dooks@codethink.co.uk" <ben.dooks@codethink.co.uk>,
        "kurahul@cadence.com" <kurahul@cadence.com>,
        "sparmar@cadence.com" <sparmar@cadence.com>
Subject: Re: [PATCH v2 5/9] usb: cdns3: drd: changed return type from int to
 bool
Thread-Topic: [PATCH v2 5/9] usb: cdns3: drd: changed return type from int to
 bool
Thread-Index: AQHWWP1GRsca5xBdWUurbAO4SuJn86kSzh4A
Date:   Wed, 22 Jul 2020 00:35:59 +0000
Message-ID: <20200722003550.GD5807@b29397-desktop>
References: <20200713100554.28530-1-pawell@cadence.com>
 <20200713100554.28530-6-pawell@cadence.com>
In-Reply-To: <20200713100554.28530-6-pawell@cadence.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <ACDCEC493209DB4783AB48DA8E519A5B@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 3f88dc68-f148-48cc-21a9-08d82dd734c2
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 00:35:59.8544
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: w6ZKAmc0DBPQGiXiaiFfqEMRz1ncxPR2S/z3l8a1f5lFeqYB5K+75eySEUg66JjUL2+uCDYa48MKOmOrJk+pNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6440
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-07-13 12:05:50, Pawel Laszczak wrote:
> Patch changes return type from int to bool for
> cdns3_is_host and cdns3_is_device functions.
>=20
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>

Reviewed-by: Peter Chen <peter.chen@nxp.com>

> ---
>  drivers/usb/cdns3/drd.c | 16 ++++++++--------
>  drivers/usb/cdns3/drd.h |  4 ++--
>  2 files changed, 10 insertions(+), 10 deletions(-)
>=20
> diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
> index 05a9f7d54c46..6fe092c828b3 100644
> --- a/drivers/usb/cdns3/drd.c
> +++ b/drivers/usb/cdns3/drd.c
> @@ -83,25 +83,25 @@ int cdns3_get_vbus(struct cdns3 *cdns)
>  	return vbus;
>  }
> =20
> -int cdns3_is_host(struct cdns3 *cdns)
> +bool cdns3_is_host(struct cdns3 *cdns)
>  {
>  	if (cdns->dr_mode =3D=3D USB_DR_MODE_HOST)
> -		return 1;
> +		return true;
>  	else if (!cdns3_get_id(cdns))
> -		return 1;
> +		return true;
> =20
> -	return 0;
> +	return false;
>  }
> =20
> -int cdns3_is_device(struct cdns3 *cdns)
> +bool cdns3_is_device(struct cdns3 *cdns)
>  {
>  	if (cdns->dr_mode =3D=3D USB_DR_MODE_PERIPHERAL)
> -		return 1;
> +		return true;
>  	else if (cdns->dr_mode =3D=3D USB_DR_MODE_OTG)
>  		if (cdns3_get_id(cdns))
> -			return 1;
> +			return true;
> =20
> -	return 0;
> +	return false;
>  }
> =20
>  /**
> diff --git a/drivers/usb/cdns3/drd.h b/drivers/usb/cdns3/drd.h
> index 04e01c4d2377..35b6d459ee58 100644
> --- a/drivers/usb/cdns3/drd.h
> +++ b/drivers/usb/cdns3/drd.h
> @@ -153,8 +153,8 @@ struct cdns3_otg_common_regs {
>  /* Only for CDNS3_CONTROLLER_V0 version */
>  #define OVERRIDE_IDPULLUP_V0		BIT(24)
> =20
> -int cdns3_is_host(struct cdns3 *cdns);
> -int cdns3_is_device(struct cdns3 *cdns);
> +bool cdns3_is_host(struct cdns3 *cdns);
> +bool cdns3_is_device(struct cdns3 *cdns);
>  int cdns3_get_id(struct cdns3 *cdns);
>  int cdns3_get_vbus(struct cdns3 *cdns);
>  int cdns3_drd_init(struct cdns3 *cdns);
> --=20
> 2.17.1
>=20

--=20

Thanks,
Peter Chen=