Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Pawel Laszczak <pawell@cadence.com>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "colin.king@canonical.com" <colin.king@canonical.com>,
        "jpawar@cadence.com" <jpawar@cadence.com>,
        "ben.dooks@codethink.co.uk" <ben.dooks@codethink.co.uk>,
        "kurahul@cadence.com" <kurahul@cadence.com>,
        "sparmar@cadence.com" <sparmar@cadence.com>
Subject: Re: [PATCH v2 6/9] usb: cdns3: Added CDNS3_ID_PERIPHERAL and
 CDNS3_ID_HOST
Thread-Topic: [PATCH v2 6/9] usb: cdns3: Added CDNS3_ID_PERIPHERAL and
 CDNS3_ID_HOST
Thread-Index: AQHWWP1HRe/JjMrj3Eqt93mqctTf4akSzr0A
Date:   Wed, 22 Jul 2020 00:38:14 +0000
Message-ID: <20200722003804.GE5807@b29397-desktop>
References: <20200713100554.28530-1-pawell@cadence.com>
 <20200713100554.28530-7-pawell@cadence.com>
In-Reply-To: <20200713100554.28530-7-pawell@cadence.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <95A652F578AC1C42AF821B9D008B0751@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d349144-d5b2-44e7-6ad5-08d82dd7850c
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 00:38:14.5301
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0ppgEFWdYkckfJ9M5+kPcjZR112nyBh94iyAoLHSugB6j5fXeRPus6sFJ4xsPEyD8JtXxOS9wwHPrcVQ7UmrOA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6440
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-07-13 12:05:51, Pawel Laszczak wrote:
> Patch adds 2 definitions that make it easier to understand the code.
>=20
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
>  drivers/usb/cdns3/drd.c | 4 ++--
>  drivers/usb/cdns3/drd.h | 3 +++
>  2 files changed, 5 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
> index 6fe092c828b3..8e7673da905e 100644
> --- a/drivers/usb/cdns3/drd.c
> +++ b/drivers/usb/cdns3/drd.c
> @@ -87,7 +87,7 @@ bool cdns3_is_host(struct cdns3 *cdns)
>  {
>  	if (cdns->dr_mode =3D=3D USB_DR_MODE_HOST)
>  		return true;
> -	else if (!cdns3_get_id(cdns))
> +	else if (cdns3_get_id(cdns) =3D=3D CDNS3_ID_HOST)
>  		return true;
> =20
>  	return false;
> @@ -98,7 +98,7 @@ bool cdns3_is_device(struct cdns3 *cdns)
>  	if (cdns->dr_mode =3D=3D USB_DR_MODE_PERIPHERAL)
>  		return true;
>  	else if (cdns->dr_mode =3D=3D USB_DR_MODE_OTG)
> -		if (cdns3_get_id(cdns))
> +		if (cdns3_get_id(cdns) =3D=3D CDNS3_ID_PERIPHERAL)
>  			return true;
> =20
>  	return false;
> diff --git a/drivers/usb/cdns3/drd.h b/drivers/usb/cdns3/drd.h
> index 35b6d459ee58..3889fead9df1 100644
> --- a/drivers/usb/cdns3/drd.h
> +++ b/drivers/usb/cdns3/drd.h
> @@ -153,6 +153,9 @@ struct cdns3_otg_common_regs {
>  /* Only for CDNS3_CONTROLLER_V0 version */
>  #define OVERRIDE_IDPULLUP_V0		BIT(24)
> =20
> +#define CDNS3_ID_PERIPHERAL		1

Since you use cdns3_is_device for function name, it is
better define as CDNS3_ID_DEVICE.

Otherwise:

Reviewed-by: Peter Chen <peter.chen@nxp.com>

> +#define CDNS3_ID_HOST			0
> +
>  bool cdns3_is_host(struct cdns3 *cdns);
>  bool cdns3_is_device(struct cdns3 *cdns);
>  int cdns3_get_id(struct cdns3 *cdns);
> --=20
> 2.17.1
>=20

--=20

Thanks,
Peter Chen=