Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peter Chen <peter.chen@nxp.com>
To:     Pawel Laszczak <pawell@cadence.com>
CC:     "balbi@kernel.org" <balbi@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "rogerq@ti.com" <rogerq@ti.com>,
        "dan.carpenter@oracle.com" <dan.carpenter@oracle.com>,
        "heikki.krogerus@linux.intel.com" <heikki.krogerus@linux.intel.com>,
        "colin.king@canonical.com" <colin.king@canonical.com>,
        "jpawar@cadence.com" <jpawar@cadence.com>,
        "ben.dooks@codethink.co.uk" <ben.dooks@codethink.co.uk>,
        "kurahul@cadence.com" <kurahul@cadence.com>,
        "sparmar@cadence.com" <sparmar@cadence.com>
Subject: Re: [PATCH v2 7/9] usb: cdns3: core: removed 'goto not_otg'
Thread-Topic: [PATCH v2 7/9] usb: cdns3: core: removed 'goto not_otg'
Thread-Index: AQHWWP1HOtuwuNPaqEyD/5ami1y3VqkS8QyA
Date:   Wed, 22 Jul 2020 02:41:01 +0000
Message-ID: <20200722024051.GF5807@b29397-desktop>
References: <20200713100554.28530-1-pawell@cadence.com>
 <20200713100554.28530-8-pawell@cadence.com>
In-Reply-To: <20200713100554.28530-8-pawell@cadence.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E11D0E8FAE001341B638A777DDF2A713@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c2d439d4-d47e-402d-3640-08d82de8ac3a
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jul 2020 02:41:01.7038
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W8M44x0BE4TT05yHeoD3yQ6GAL3BbAvb4Piw73eN/GQVuSdNJMSPFWoMLPdAiTuoWCsKuEMYvODKNseejMPt0A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5318
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20-07-13 12:05:52, Pawel Laszczak wrote:
> Patch removes 'goto not_otg' instruction from
> cdns3_hw_role_state_machine function.
>=20
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> ---
>  drivers/usb/cdns3/core.c | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)
>=20
> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c
> index c498b585eb13..8e3996f211a8 100644
> --- a/drivers/usb/cdns3/core.c
> +++ b/drivers/usb/cdns3/core.c
> @@ -191,11 +191,17 @@ static int cdns3_core_init_role(struct cdns3 *cdns)
>   */
>  static enum usb_role cdns3_hw_role_state_machine(struct cdns3 *cdns)
>  {
> -	enum usb_role role;
> +	enum usb_role role =3D USB_ROLE_NONE;
>  	int id, vbus;
> =20
> -	if (cdns->dr_mode !=3D USB_DR_MODE_OTG)
> -		goto not_otg;
> +	if (cdns->dr_mode !=3D USB_DR_MODE_OTG) {
> +		if (cdns3_is_host(cdns))
> +			role =3D USB_ROLE_HOST;
> +		if (cdns3_is_device(cdns))
> +			role =3D USB_ROLE_DEVICE;
> +
> +		return role;
> +	}

Would you please improve it a bit like below:

	if (cdns->dr_mode !=3D USB_DR_MODE_OTG) {
		if (cdns3_is_host(cdns))
			role =3D USB_ROLE_HOST;
		else if (cdns3_is_device(cdns))
			role =3D USB_ROLE_DEVICE;
		else
			role =3D USB_ROLE_NONE;

		return role;
	}

Peter
> =20
>  	id =3D cdns3_get_id(cdns);
>  	vbus =3D cdns3_get_vbus(cdns);
> @@ -232,14 +238,6 @@ static enum usb_role cdns3_hw_role_state_machine(str=
uct cdns3 *cdns)
>  	dev_dbg(cdns->dev, "role %d -> %d\n", cdns->role, role);
> =20
>  	return role;
> -
> -not_otg:
> -	if (cdns3_is_host(cdns))
> -		role =3D USB_ROLE_HOST;
> -	if (cdns3_is_device(cdns))
> -		role =3D USB_ROLE_DEVICE;
> -
> -	return role;
>  }
> =20
>  static int cdns3_idle_role_start(struct cdns3 *cdns)
> --=20
> 2.17.1
>=20

--=20

Thanks,
Peter Chen=