Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp195590ybh; Tue, 21 Jul 2020 20:54:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzoulfncskuLRMz33KJQvKNoUnECcaLXfQsyj2nGl311KtXhF6czEe1FzEMGUMbDjdroycf X-Received: by 2002:aa7:c5d4:: with SMTP id h20mr28170660eds.115.1595390085283; Tue, 21 Jul 2020 20:54:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595390085; cv=none; d=google.com; s=arc-20160816; b=ux6bIjM6yCfksTGMcelQ6kgSmcoia0FWBWzzN9o1yNOVLtwlAcmT2JrBalBTn7JqSZ NuViB+3Q30K+RdsGhVKglicT4vtgC89R0QUSeintrj2uohysSoHMeQhMz8WGD1XI+NS1 0CM7VrFhhp4bp0P+vT3x8WIAU4Q/Zx6l1n/EyoYfr8hOq7GXKsSpJwCaGXX9pLiDLeYp ussB5Y06KWqxKOYJTsz+MDeqFF+DoLM7VNqqKEx9ZojNGTIPWvFj0VPlwt7tDzsiUwj0 gL9C/u2jsRNoS/TOqrFNzKNLML8QvQjS+FA5AOsFfzBU6um+x09W+68TIWNMkYstaNKT feIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=Kv16/ZtjvsqzwhA67RXGlNKlymdPTZgYcbB4t9a+XQQ=; b=j2pYC5XXi9sgZxgGDsr02RKty1gN4U8E2y5//NOOX7Dirb1hb+Patdax8OPWXHTJpn 7JR0SkvtYUaR5B7HpwQ2GWH3CIK6rK5IZgyBo5eV+JGvdqymdqzg7MIxjKtpP0mAjEtV GtADpXeQHD+ZwmgqwqFH+n8D8CIxDsYt5zNo0o9J96h6eDH+lkghTaB5d/GhyXvPnxWL LkQAR+v/ehHDoxirh7Km+mvhaks4Re9siyGmtAMBA/CqvszyNoN0m3G4qS/CCXImpsDI VgUJ4bPqqGsu9lqE0uyFfvEK/G6uEHiVOar7TvpDOgKtbKuCpf3QJ+2bwOG7sCdRCEY2 F2FA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=teU76l4o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c6si13912708edv.311.2020.07.21.20.54.21; Tue, 21 Jul 2020 20:54:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=teU76l4o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731886AbgGVDyK (ORCPT + 99 others); Tue, 21 Jul 2020 23:54:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731793AbgGVDyJ (ORCPT ); Tue, 21 Jul 2020 23:54:09 -0400 Received: from mail-pl1-x642.google.com (mail-pl1-x642.google.com [IPv6:2607:f8b0:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A53D9C061794 for ; Tue, 21 Jul 2020 20:54:09 -0700 (PDT) Received: by mail-pl1-x642.google.com with SMTP id p1so305979pls.4 for ; Tue, 21 Jul 2020 20:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Kv16/ZtjvsqzwhA67RXGlNKlymdPTZgYcbB4t9a+XQQ=; b=teU76l4onNGxGGAkHnfmRlYyyoNjrAl9sepXE+/Q09UB3kodYSezX/yBSJS+QYvmNa rveHjIAqpceNwjoChgvGHRZc/hnLc9EB7NI7dtGueridPlvY10dO856x0XkjS7tWECEE tVH7ySR5EdkQQtKFM62MYFe0IgX4VMKj2lpFGVI9keCTmxOTfV65woEDPjrsPLkvR5LJ x+FvkLyBB9D4Mw03wpJH6B+05Otq8WappntG5IUU2LIcCjclzqC8nJsEtGJkxPMhjFkG VoEhVcA/8PfcbbNxQYhyg0EcdY/nqDwa2oOpkh6w16ESpfoybMuLkNtPcJK5rM9EclS1 yMmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kv16/ZtjvsqzwhA67RXGlNKlymdPTZgYcbB4t9a+XQQ=; b=mNIgvyJcv3dmQV7NLE1Q7uI+wgtWC8PH1uPCveFDrR3ZoWs0/d2fX2HOF7o1BFBc0t v2huT6i20+fdinlmcLtGpeQkdpjjEHDYSGUaDrahxR1aRKGFPYXfVbR4GFtIJDEXvbY3 ShkvXsQEw7K0apDqLEKfYbSDKVOR6HgB2QAtnljlwtnnyHdzbcNdc9cfS559+xeohv+3 HIQ7ZLnDAKaXqpNVPecXojFWFm99sv8dtKx0VyS6BTUSqN/orQ9+LvFvUhbRgjc6nAOu W57ADDdFmMOng6G/IG0ko+4pTGkXflD9/7fvbpY/33cy5swjC2HP8eeGiNuDniqHxl01 2IXw== X-Gm-Message-State: AOAM5315QXBrlX9SSoN4ZnT3LF1bxuTx5rzV43rwlFlRSc2bu6v3x0Oz QIswX/3KBI/rO8OwmLuylAObcin0ph4XJ3r/CaA= X-Received: by 2002:a17:90b:1045:: with SMTP id gq5mr8043357pjb.30.1595390049137; Tue, 21 Jul 2020 20:54:09 -0700 (PDT) MIME-Version: 1.0 References: <20200721220035.32584-1-jcmvbkbc@gmail.com> <20200721230426.GC2786714@ZenIV.linux.org.uk> In-Reply-To: <20200721230426.GC2786714@ZenIV.linux.org.uk> From: Max Filippov Date: Tue, 21 Jul 2020 20:53:57 -0700 Message-ID: Subject: Re: [PATCH] xtensa: fix access check in csum_and_copy_from_user To: Al Viro Cc: "open list:TENSILICA XTENSA PORT (xtensa)" , Chris Zankel , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 4:04 PM Al Viro wrote: > > On Tue, Jul 21, 2020 at 03:00:35PM -0700, Max Filippov wrote: > > Commit d341659f470b ("xtensa: switch to providing > > csum_and_copy_from_user()") introduced access check, but incorrectly > > tested dst instead of src. > > Fix access_ok argument in csum_and_copy_from_user. > > Applied, with apologies... Which tree do you want it to go through? > I'm dropping it into vfs.git#fixes, will send to Linus unless you > prefer it to go some other way... NP. Anything that will go into 5.8 is good. -- Thanks. -- Max