Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp237102ybh; Tue, 21 Jul 2020 22:24:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGfocVthMcHte7H6e5QIhL69wkOHDF3rYPBslNruRt/al1MqfgfAOpN9EWrmOc/MDhCacx X-Received: by 2002:a17:906:3650:: with SMTP id r16mr27257559ejb.465.1595395453249; Tue, 21 Jul 2020 22:24:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595395453; cv=none; d=google.com; s=arc-20160816; b=aBqSwVIFolnx6AImBWyG/Y5vlxiHjKsJEliX5Iz4agOf2hQTSerNvbIR7saqAt5CkN oWS8aI2PjaSCZvgHZ7/1hmOTD87yrJGEUDAZEOFeyDhXo64WE7Zv2EQcuuaXCpCl/p1l DQlPhH+Ohds3No5e4aq4O1f9ll11Z9b2ErxbRMmUnq5YX4AMBzP9LrNuYT8kJTFdM4kH j3aNSqDcoyMq3MJ33zCCj75dyfzT6d1RdiPFPshIP1LjXhboX9X4pYkMcYorzkZWtHKb Zj12YjHEUYRBXWKoA/Xy8VQGZtaJkyknV4sGuqz6Kb66YwuMEht8SG2DZre9I8LxAvnf lMaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Dmd/Tm2NKIlPmtmf250Rr5po/tBi+tVL5ukErGpu6/M=; b=al+Cbyix+s/3SGqyEw5YBeeITie0VwIiIaSB35oD3nU69Wqy9ru937yy38ASakjY9k +WAKp+q1o+fyv9anjm2jdf8ByqAAl3x6DaWM6w/wCp/3jRt1eLwLsOiD+LCzuhDTHnF3 sbb34k62T4IQ9rErnmcde+bgtMGZ7iiF9fbtSEaVMg7OKip3H/W1bcABgWltEOQimQSp oxsEfZsJenfECP8q83FUkkVmr8M0MXxEALjebOM6C5Be9QN+OCZS2lrBAl4YSYnWglbg jRXXlw1U2iWCBJnzJxrt5O/JDjXstTXX2aOHee0WghCLVpgoqo/U+DswysCJeSFsE5nu TikQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=fZW1F7Dl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q20si15767405ejb.422.2020.07.21.22.23.50; Tue, 21 Jul 2020 22:24:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=fZW1F7Dl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=bytedance.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726669AbgGVFTR (ORCPT + 99 others); Wed, 22 Jul 2020 01:19:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726147AbgGVFTQ (ORCPT ); Wed, 22 Jul 2020 01:19:16 -0400 Received: from mail-pj1-x1042.google.com (mail-pj1-x1042.google.com [IPv6:2607:f8b0:4864:20::1042]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A65AC061794 for ; Tue, 21 Jul 2020 22:19:16 -0700 (PDT) Received: by mail-pj1-x1042.google.com with SMTP id md7so558487pjb.1 for ; Tue, 21 Jul 2020 22:19:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Dmd/Tm2NKIlPmtmf250Rr5po/tBi+tVL5ukErGpu6/M=; b=fZW1F7DltafThR0vBDMpn78I1muDP0lGZn3RhT1ELTFKpoeX8LXcT8AlQBpWyexuw0 SaOCdrpFD6Btz0PYfdejP8xgqBzdxb6cIwiEbUkCsix7k0RPv/Rqxd+khvFbANg8mvEu Tf8EX+3Fg/sG2aUMJ23I+Lve68oOIld2MKKXqsC3M3Ou35QKn6jaI/Ml3moPaK6lgPTB V8xSL3NXBlulAaqHu/8dvSZlaVfJNh+HyBQSe2ZHB+fL6eMRyMb9UT2Ci4ITKksV1gA4 k8vTH33euyrNNE+FsnGAByJLOlZfWdtTdfhh/9CAv6S5K3f9M8SIRJeRgu4ux08/UjKn 3xdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Dmd/Tm2NKIlPmtmf250Rr5po/tBi+tVL5ukErGpu6/M=; b=frl5WoG8f9vY+GBY5twtPBxqWtse/fPtIQ4cYxZ4VNGBaUD6QOLvcABMFVeq+xPVPN yJ9Vh27NSVuh/bAvj1keCTBz4VPBZz5YLWYAFmuZM2CKmA1UaL34OxMTVSBmT2fAXeeV YVFDiQX4UYbw5FDg6sOwvw4QB4YelFDA6jDhWEPuu1Hi77XWzbMdpZu5nyihBdZP465+ 1+8ZCAPrCqVb8XCheq/acXhBtlaXyq+tu2w82RMCmJxdF8+q28pS92YtoUEDtU+rvgaJ tq0W7vpo/HR9J4gGIMtftpEBnENkcECSJwgZQzU+u0RDyReeTgraYGOgr31D9VWlPUeO OmCw== X-Gm-Message-State: AOAM532p8jYK0+FUCkchSemcXeu7IzWfPbgzJi7PLUFrGt4QA4RqiBqW P/62pbltzk9uN09V7rHAM3shlA== X-Received: by 2002:a17:902:8204:: with SMTP id x4mr26310498pln.16.1595395155749; Tue, 21 Jul 2020 22:19:15 -0700 (PDT) Received: from C02ZK051LVCK.local.net ([61.120.150.77]) by smtp.gmail.com with ESMTPSA id h3sm4971462pjz.23.2020.07.21.22.19.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 Jul 2020 22:19:12 -0700 (PDT) From: Xin He To: airlied@linux.ie, kraxel@redhat.com, daniel@ffwll.ch Cc: dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, Xin He , Qi Liu Subject: [PATCH] drm/virtio: fix memory leak in virtio_gpu_cleanup_object() Date: Wed, 22 Jul 2020 13:18:51 +0800 Message-Id: <20200722051851.72662-1-hexin.op@bytedance.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Before setting shmem->pages to NULL, kfree() should be called. Signed-off-by: Xin He Reviewed-by: Qi Liu --- drivers/gpu/drm/virtio/virtgpu_object.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c index 6ccbd01cd888..703b5cd51751 100644 --- a/drivers/gpu/drm/virtio/virtgpu_object.c +++ b/drivers/gpu/drm/virtio/virtgpu_object.c @@ -79,6 +79,7 @@ void virtio_gpu_cleanup_object(struct virtio_gpu_object *bo) } sg_free_table(shmem->pages); + kfree(shmem->pages); shmem->pages = NULL; drm_gem_shmem_unpin(&bo->base.base); } -- 2.21.1 (Apple Git-122.3)