Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp268272ybh; Tue, 21 Jul 2020 23:29:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxshhWwaCIwLTNDvzAWMFck5RkVJlHOx+g12hPTkpXrz65+bmScuj6XbPRlOXYSwpcFLnoB X-Received: by 2002:a05:6402:2064:: with SMTP id bd4mr28735277edb.180.1595399351372; Tue, 21 Jul 2020 23:29:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595399351; cv=none; d=google.com; s=arc-20160816; b=sxv0baDH6lxKqpC/xGiWNG0nHOYMary3kQKUAooE200qkQ3vBlNLQckRCRXr4dudSA un5sPlLqFfovnN6kRA6wJvj5lZmH3EVLQ5dnfendjSEAolKYCUlzd1Y5MwG7hXNs9+S2 a6ft7RBS4WEs5XP2jTAO8RQLK1l5Sqk6NrZPFdvsG9ONRB6D6cR/+Xk30JGXShteXEvb fokEDRu6x8MRUfaWu/mFbNDfaRu/US4VvzQMR2c+C6+ypfzkkxRrg9hzK4BWFcGPG17M JT821hE/nixx7EizCJBOsa0CxUOHST3My1YT6AtsxoT7NgYcRNF+RacYO5FFdUB8ihTQ xYdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=toLJ0vqGJpB+m2DWzx8OUV3mzNvbIyso0hs1e0NzMQw=; b=nUXypqIGPHBkTCbgVRDGqCGhpRIhUX+mYlM0yAPb5f6gudX0YzW+7rBoQPaxKu6PS+ i4LICUSodCJuZMpRPOZ/yHtlb4tA9vQi48QtOSkOPpUr7J5NPNXrcrbJIi68kPJM8sKs UhZ+dvZJVR+cAGgviiUmrP7Db8EGbWLiD2mGej8YzrDdfGH0hAyhrGV9H+CoxzIG5qnh nZBglnxm35idnyNOO/ywSJ2TmkBaT8FhL8whfqrNy0VUloBF1gq8kzoKXa6vamSFEk2G BTuFESk6p8tR28CSDHKwOOfAOYFyaHpHynABWPC/h9hBijUduKd5zFbb71GKJSZdzQm0 qEug== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=Tn4xalF1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r21si12572548ejo.707.2020.07.21.23.28.48; Tue, 21 Jul 2020 23:29:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=Tn4xalF1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729114AbgGVG0e (ORCPT + 99 others); Wed, 22 Jul 2020 02:26:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728871AbgGVG02 (ORCPT ); Wed, 22 Jul 2020 02:26:28 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8625C061794; Tue, 21 Jul 2020 23:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=toLJ0vqGJpB+m2DWzx8OUV3mzNvbIyso0hs1e0NzMQw=; b=Tn4xalF1YN7Wqp1NXQJpA/hlZ3 Zzeym0fSToI0ZjtblIQF0KaR8LI/0QKwnX317OWhJ4RanjyvysIbdqI0KEXF4q9cdGzPwj8fs+ft9 C6M4D+H0TBRp0o6dYj8TwKrHaf5XOhXj+8e9RcuISGAUSLHAkBYcWdvL4Vy14GO3fI/Bq3XgHW1xo 3YDKwttuYSv4GlmUbJUyoOWATp5d4Hb8TuN1sOYwHIl2jcXF11h/9Vl8LfXE3faJ8dJY0Bu5m6We5 Bsojk10wIqdaLJmYRWg3Fa/bZBTq9m0Z+VZ6ls1UGmgfGGrNwdefM52lMe0Xd5NkLZOPrEXfOdYHE 3WaQDsUw==; Received: from [2001:4bb8:18c:2acc:e75:d48f:65ef:e944] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jy8Cp-0004m8-AG; Wed, 22 Jul 2020 06:26:20 +0000 From: Christoph Hellwig To: Jens Axboe Cc: Song Liu , Hans de Goede , Richard Weinberger , Minchan Kim , linux-mtd@lists.infradead.org, dm-devel@redhat.com, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com, linux-raid@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, cgroups@vger.kernel.org Subject: [PATCH 03/14] drbd: remove RB_CONGESTED_REMOTE Date: Wed, 22 Jul 2020 08:25:41 +0200 Message-Id: <20200722062552.212200-4-hch@lst.de> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200722062552.212200-1-hch@lst.de> References: <20200722062552.212200-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This case isn't ever used. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_req.c | 4 ---- include/linux/drbd.h | 1 - 2 files changed, 5 deletions(-) diff --git a/drivers/block/drbd/drbd_req.c b/drivers/block/drbd/drbd_req.c index 674be09b2da94a..4d944f2eb56efa 100644 --- a/drivers/block/drbd/drbd_req.c +++ b/drivers/block/drbd/drbd_req.c @@ -901,13 +901,9 @@ static bool drbd_may_do_local_read(struct drbd_device *device, sector_t sector, static bool remote_due_to_read_balancing(struct drbd_device *device, sector_t sector, enum drbd_read_balancing rbm) { - struct backing_dev_info *bdi; int stripe_shift; switch (rbm) { - case RB_CONGESTED_REMOTE: - bdi = device->ldev->backing_bdev->bd_disk->queue->backing_dev_info; - return bdi_read_congested(bdi); case RB_LEAST_PENDING: return atomic_read(&device->local_cnt) > atomic_read(&device->ap_pending_cnt) + atomic_read(&device->rs_pending_cnt); diff --git a/include/linux/drbd.h b/include/linux/drbd.h index 5755537b51b114..6a8286132751df 100644 --- a/include/linux/drbd.h +++ b/include/linux/drbd.h @@ -94,7 +94,6 @@ enum drbd_read_balancing { RB_PREFER_REMOTE, RB_ROUND_ROBIN, RB_LEAST_PENDING, - RB_CONGESTED_REMOTE, RB_32K_STRIPING, RB_64K_STRIPING, RB_128K_STRIPING, -- 2.27.0