Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp274569ybh; Tue, 21 Jul 2020 23:42:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxuahn/LcHSCJfpdoRKxfr06WXcM/9v0RXlzEphIi/x2MuztMBLMhWKtvNmujV1aKvj/rVa X-Received: by 2002:aa7:ce91:: with SMTP id y17mr29652028edv.105.1595400144895; Tue, 21 Jul 2020 23:42:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595400144; cv=none; d=google.com; s=arc-20160816; b=NZxgu2/ocQKj8woCuNzxtezhRTLvwhxvlpMDteXrJGwMeAkxnd2H/PYEELYMG69puP h8NMbeyYCcTbrbqFEoMSSesBGBTtC/CmU17sTI2BuYjcG8wnQLCTbguUkY45lqRjJfCL X9e5W9YaBWtVkDvXeJITZa0cnYY7ETyXvccmYgq9F0WZWe0kLsmw9NT/dXe6I0vcYty9 rlKjJULHtAfS6SvcQ9/6/0wb/P9gjw2gfktqurDW6rdIFqSJ0qXS55LYvfWXcu0iNOvF fv86Vj1pW7YwEHuSWo5uuCpYpDm6Nsa6bQnw1ss3ugGSkgSzj+lP0vftEzbGdn1gDrXT Il2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=QBlT0rHy766TwjM3WcKRo2rpVMbBP9MM+KvXAGU8B1U=; b=KOwYTdx1PFoSooNEVtnaTAHzis6YCZgbZlani4F41jUXCXHunxMZEPbcLpu5xI59i3 W6MHjTOVorY6CHs6Am8J4LIF+6IYX8YdV3u39RKpFjke9DvZXkTAWflI0ToG0n9P5F8l WXsSflbasJtewd1xDANRUcT/IVUet2fF9RU5hBlMxSFlW9pm7c2A9QvysnsK5AJzXqQd 6HjBPyOoBN78SF7Ugf0zHIiXM30l8K85aq2GEp2gVGA2+PhmnUcvPtbfhHr3HGinYw9E wnwVMZvNt/Wjg4w+TXqmxTduwBTi0Oygy5TZLjbVeVq/9NE5efxuE26fHqIC8SaBPkQr +TxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b="j/H04Sbn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n1si89898ejc.134.2020.07.21.23.42.02; Tue, 21 Jul 2020 23:42:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b="j/H04Sbn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729560AbgGVGle (ORCPT + 99 others); Wed, 22 Jul 2020 02:41:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726736AbgGVGld (ORCPT ); Wed, 22 Jul 2020 02:41:33 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6833DC061794; Tue, 21 Jul 2020 23:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=QBlT0rHy766TwjM3WcKRo2rpVMbBP9MM+KvXAGU8B1U=; b=j/H04SbnJSgNEzPiUMiUaBgDbK 0qYuXCf5XchuQ3KQWNP+I2RRJdOTDs/ci0ecLLjA+FOHXIlT/TWuC0YcdnmbjzYbG2ggKEKYFvYfC suWD0aVodyFljngeBigiglu4KK5XeN4klkCbfTE/lQsFHhsFQhFoUOkc56R6QHyCZ1WEd4VDA+ZWl yf8zweSeVZzdizInaTNxn0gXnpWrlbRi8f9VWvYhF2JakKSqY8jDhkQy07JRmRfMMYi+AHVWC4Jbp l9Mo0O+VkhRfTm9vd1pAI5XzkuoRtafEHmbLZXXiASAEXrxN9SYWKtNgHfsKzVs0y2BWyctFLrHnT ZjTIpL8Q==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jy8RE-0005hr-Dv; Wed, 22 Jul 2020 06:41:12 +0000 Date: Wed, 22 Jul 2020 07:41:12 +0100 From: Christoph Hellwig To: Daejun Park Cc: "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "asutoshd@codeaurora.org" , "beanhuo@micron.com" , "stanley.chu@mediatek.com" , "cang@codeaurora.org" , "bvanassche@acm.org" , "tomas.winkler@intel.com" , ALIM AKHTAR , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sang-yoon Oh , Sung-Jun Park , yongmyung lee , Jinyoung CHOI , Adel Choi , BoRam Shin Subject: Re: [PATCH v6 2/5] scsi: ufs: Add UFS-feature layer Message-ID: <20200722064112.GB21117@infradead.org> References: <231786897.01594636801601.JavaMail.epsvc@epcpadp1> <963815509.21594636682161.JavaMail.epsvc@epcpadp2> <231786897.01594637401708.JavaMail.epsvc@epcpadp1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <231786897.01594637401708.JavaMail.epsvc@epcpadp1> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2020 at 07:40:40PM +0900, Daejun Park wrote: > This patch is adding UFS feature layer to UFS core driver. > > UFS Driver data structure (struct ufs_hba) Independent of the problems with the concept of HPB, this patch is just really bad software architecture. Don't just add random indirection layers that do represent an actual real abstraction. As-is it is just another crap hook layer without a proper absteaction. Nacked^2-by: Christoph Hellwig