Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp315296ybh; Wed, 22 Jul 2020 01:06:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLFP9yDOOiJqFAVqO70iQ3ptqq7MFGk6WU0tJ9hOmV2u9ejDJ33u3nCGa7rcqb9W+U29OZ X-Received: by 2002:aa7:c2cf:: with SMTP id m15mr28473981edp.27.1595405180895; Wed, 22 Jul 2020 01:06:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595405180; cv=none; d=google.com; s=arc-20160816; b=PJ9g5+Fqvec4JpdaPyIUSFs7++lRJWEp+JgQ1rNPuTMek87ld77PCV8u3VVZwh7YVY lJzHJTVBUSUOvJTkWwE2L678IipjktasZF3UukN6nFE+pF2Ts8d2G2DPpPZSEF/q2WzD MvDSZPDLHBgaxvuLYxNUiSn2ZkEtjT6Ho00g/Dc/rY+0eHHkmsiE7b9yA+YuDdn/dufF K5FjdRZYUhhmHt+GUxv6PDFsnuQ8Lw3+OShTx20nReqs7saHwVc8OjIDvifUr/daB9CC i8rW8o3eP6Oi9EyjmHzae8YBHZoF6VCSYXH64IR8qmRDND8SuBIvyLVR84q3LzMFitn2 1npw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=JRoBrTsi+7qJgQ1RtSOq03pDBlC5RHyF6zzAMJ/e2zk=; b=aNGDMnXt43Hym8yPNZncvukuXW4oJ09vlbHHb3F6o8IPhIENAdmyZ6ukinlo0aW0yB n9T+1OlmLKb6jOLTieIQ2uZRZ6f+HcyltW1cZGrpX7l15OO28Ll1IHwCv4fpuBeXuY5n tE5ct/b/mEhOb6fSEbZRm44dxl8OPqoTrVjosayhwg54yvXUu+6831EB4SOqF0Rjtbkv 1EmYXGa3lCsRhTJ3Gb5ezQIXrrHd+ltClo3e8BUrMtK2nPdZGOp+yn6TfqhwnMtKbZUB qryqfpnrBa0if9HJJ7g1oI6DV4nnqaAJtA9tWh8R5AgSRScu+LOF1sa9toT3CV1EKuAE wFjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g27si11468915ejb.556.2020.07.22.01.05.58; Wed, 22 Jul 2020 01:06:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728220AbgGVIFf (ORCPT + 99 others); Wed, 22 Jul 2020 04:05:35 -0400 Received: from mx2.suse.de ([195.135.220.15]:41976 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726141AbgGVIFf (ORCPT ); Wed, 22 Jul 2020 04:05:35 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 0EB4CAFE8; Wed, 22 Jul 2020 08:05:41 +0000 (UTC) Date: Wed, 22 Jul 2020 10:05:30 +0200 From: Joerg Roedel To: Mike Stunes Cc: Joerg Roedel , "x86@kernel.org" , Tom Lendacky , "hpa@zytor.com" , Andy Lutomirski , Dave Hansen , Peter Zijlstra , Jiri Slaby , Dan Williams , Juergen Gross , Kees Cook , David Rientjes , Cfir Cohen , Erdem Aktas , Masami Hiramatsu , Sean Christopherson , Martin Radev , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , "virtualization@lists.linux-foundation.org" Subject: Re: [PATCH v4 51/75] x86/sev-es: Handle MMIO events Message-ID: <20200722080530.GH6132@suse.de> References: <20200714120917.11253-1-joro@8bytes.org> <20200714120917.11253-52-joro@8bytes.org> <40D5C698-1ED2-4CCE-9C1D-07620A021A6A@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40D5C698-1ED2-4CCE-9C1D-07620A021A6A@vmware.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hmm, I have a theory ... On Tue, Jul 21, 2020 at 09:01:44PM +0000, Mike Stunes wrote: > If I remove the call to probe_roms from setup_arch, or remove the calls to romchecksum from probe_roms, this kernel boots normally. > > Please let me know of other tests I should run or data that I can collect. Thanks! ... can you please try the attached diff? diff --git a/arch/x86/kernel/sev-es.c b/arch/x86/kernel/sev-es.c index 251d0aabc55a..e1fea7a38019 100644 --- a/arch/x86/kernel/sev-es.c +++ b/arch/x86/kernel/sev-es.c @@ -389,7 +389,8 @@ static bool vc_slow_virt_to_phys(struct ghcb *ghcb, struct es_em_ctxt *ctxt, pgd_t *pgd; pte_t *pte; - pgd = pgd_offset(current->active_mm, va); + pgd = __va(read_cr3_pa()); + pgd = &pgd[pgd_index(va)]; pte = lookup_address_in_pgd(pgd, va, &level); if (!pte) { ctxt->fi.vector = X86_TRAP_PF;