Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 22 Jul 2020 10:28:45 +0200
From:   Wolfram Sang <wsa+renesas@sang-engineering.com>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc:     kishon@ti.com, vkoul@kernel.org, geert+renesas@glider.be,
        linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] phy: renesas: rcar-gen3-usb2: exit if
 request_irq() failed
Message-ID: <20200722082845.GB1030@ninjato>
References: <1594986297-12434-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
 <1594986297-12434-3-git-send-email-yoshihiro.shimoda.uh@renesas.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="rS8CxjVDS/+yyDmU"
Content-Disposition: inline
In-Reply-To: <1594986297-12434-3-git-send-email-yoshihiro.shimoda.uh@renesas.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--rS8CxjVDS/+yyDmU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 17, 2020 at 08:44:57PM +0900, Yoshihiro Shimoda wrote:
> To avoid unexpected behaviors, it's better to exit if request_irq()
> failed.
>=20
> Suggested-by: Vinod Koul <vkoul@kernel.org>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Makes sense to me.

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


--rS8CxjVDS/+yyDmU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl8X+L0ACgkQFA3kzBSg
KbbciA//fMAool2PdEJqf3rxrNzqqzPYYgMjFQmxW46mh71RAsjEvlIKNcwHPUiH
LcSTZt33k2Ef5kfE/ByxiHCzxZEncMtPqjjfsx5wsxU930K5Cm+uTR1hjOYHkjfC
oedk1vKAhQJB02UtrlNa8ahdkJGvXM8BQ+vBqjxuyFpowfHmRuCB2bUepqFKbY3h
PqfYurpytpIv+8LJHpnAgbzOKanzYPS3TcHZ99TCxSBK8c8sp/s0+P09qI5PNMn+
RTJjfHEbUef8O6q06P+ag4BfRGQ0SY0GrZR32G3vKnT1SL2A02ZB85dxHJAYSu6h
8zeKYDm9kpoayIQdHw3b+zcq+KMoBBwezrUbxnntiWTQK/2r741kOJ++RlU8fXqW
fmCatT+S2MO/KPP3YeT6gJoKY0l8VhxIRPr57Jhbl4vKqBYRSwHrrOtvz8Ue4P01
mhcawkYSjKJuFu6skzlQ06WfZYgy/HJGIpMmaMmjj8UzoEKwEih92NiL9mbe0AG6
RMPflXX/RaH1HoeVlqYKnzCCGNc7UXRvxDi+SPPa0F+OwGTkNByfVPgCny+JogQw
nwA9jXj8mppzEboYBz4ro3nx8DYVHA629o/dVsgMrz8j26PW1SKaE8SXm7q4aJJA
heW3POM/i6ruHJ1HmxH9QFNYu7mLM8myz+Mf407ajWXxgzh9fQE=
=7PRm
-----END PGP SIGNATURE-----

--rS8CxjVDS/+yyDmU--