Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 22 Jul 2020 10:27:39 +0200
From:   Wolfram Sang <wsa+renesas@sang-engineering.com>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc:     kishon@ti.com, vkoul@kernel.org, geert+renesas@glider.be,
        linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] phy: renesas: rcar-gen3-usb2: move irq
 registration to init
Message-ID: <20200722082738.GA1030@ninjato>
References: <1594986297-12434-1-git-send-email-yoshihiro.shimoda.uh@renesas.com>
 <1594986297-12434-2-git-send-email-yoshihiro.shimoda.uh@renesas.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="1yeeQ81UyVL57Vl7"
Content-Disposition: inline
In-Reply-To: <1594986297-12434-2-git-send-email-yoshihiro.shimoda.uh@renesas.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--1yeeQ81UyVL57Vl7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 17, 2020 at 08:44:56PM +0900, Yoshihiro Shimoda wrote:
> If CONFIG_DEBUG_SHIRQ was enabled, r8a77951-salvator-xs could boot

"could not boot"

> correctly. If we appended "earlycon keep_bootcon" to the kernel
> command like, we could get kernel log like below.
>=20
>     SError Interrupt on CPU0, code 0xbf000002 -- SError
>     CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.8.0-rc3-salvator-x-00505-=
g6c843129e6faaf01 #785
>     Hardware name: Renesas Salvator-X 2nd version board based on r8a77951=
 (DT)
>     pstate: 60400085 (nZCv daIf +PAN -UAO BTYPE=3D--)
>     pc : rcar_gen3_phy_usb2_irq+0x14/0x54
>     lr : free_irq+0xf4/0x27c
>=20
> This means free_irq() calls the interrupt handler while PM runtime
> is not getting if DEBUG_SHIRQ is enabled and rcar_gen3_phy_usb2_probe()
> failed. To fix the issue, move the irq registration place to
> rcar_gen3_phy_usb2_init() which is ready to handle the interrupts.
>=20
> Note that after the commit 549b6b55b005 ("phy: renesas: rcar-gen3-usb2:
> enable/disable independent irqs") which is merged into v5.2, since this
> driver creates multiple phy instances, needs to check whether one of
> phy instances is initialized. However, if we backport this patch to v5.1
> or less, we don't need to check it because such kernel have single
> phy instance.
>=20
> Reported-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Reported-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Fixes: 9f391c574efc ("phy: rcar-gen3-usb2: add runtime ID/VBUS pin detect=
ion")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Yeah, makes my boards boot with CONFIG_DEBUG_SHIRQ!

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


--1yeeQ81UyVL57Vl7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl8X+HcACgkQFA3kzBSg
KbZETRAAl7dF5VEdTxe1lDE0sOfYgIaIhGPjpbmQnpQAgMjtmaWRh17dRsqY8mMO
NkJn2sAJx+kCoMfJM7S2dXFKEKLAU5RDYfqacBNJsaz059wabq/Vt2hCV/gQhYmM
5ScB0UpZ8V3rNVr/Y8vZKxzvnxprjn7yp94ZY1IfPPjaiuz7Oxw1p5FI4X7RuRrW
et+bwSUK9R8EDejID8knGMlFWcy3VSl63XDpAZ1moZMF9BvOKIh+/Yip2J/F6mD9
zJbujJ5HLgJnGs3uxuFH7q+3TDM8K+s91bkMGcvJa0JJ8EZRwafcqd70moIdz/nS
s/hE1Ebicn/2Li/B+WQxM7MrvL0YUTcbGywTqPculK1ZdEmQ+z2mEuHy6LIGcRW3
o//D3/rKaABo9lQskK2Go6czF72HX0ypjJMfnFs0XMSMCqiOxULwWx62RN9x7j70
kUDpD47f4QTC440Kh8JsFFJxMW08Oi3ba2o2d9cAXF9rNB9FBdFO7MIEiE+AQfo/
IikqAPf7z8jc/+6SjvlvNf75EvJ1OtlTitRtEXKkm9KbRAdL/xonJgjHGY9Jz3rp
iWSoLFKu/pIT++ObJ30fRtNogOO+l+K6XlJNYv8MEJs8BHDSiCEe6D7T/lojD9bX
QXTbOYXTe7GKSmjYYjzr1NZwVoeHN/QvZq8YZWpcAgCIVrrvBJ0=
=GT6K
-----END PGP SIGNATURE-----

--1yeeQ81UyVL57Vl7--