Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp433063ybh; Wed, 22 Jul 2020 04:29:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZDD2FrHvnt6breOus9gaOBS5QJVnl8rotpWIRps67W3iR1Br8h5oFu3ipeQJHIbuEH868 X-Received: by 2002:a05:6402:1803:: with SMTP id g3mr29035533edy.377.1595417342749; Wed, 22 Jul 2020 04:29:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595417342; cv=none; d=google.com; s=arc-20160816; b=gDkxNRmiM4H0PTebIyt0bOO0KEQ+bFfBgeWeLjl2dM0N09dGxXqkhrd69MX9z/4yg5 pmRwkRT/TYO1MyhqvgDH46G5DvQv4hpkF9LjHNJqe5PDsKoGnSmtv4fmtstYo9iQgWEf 25tvoSzx5E+T4OqeZpj3Tgu6UjdPwdMu481PsukHQJ1U4+pWu4I+KF4UwbqJzqUzv4dn 2aTbOPk2qPXh89DIB4hEC5MeKj+QNyL293wBIvT+C/Vm4/zRmeG8pfx6HIzyCxQ+L0KN rFQGpHHCKbsgafQogUNwnvyXWBq1sOfGqkBJ4VSGC1TzmADuowk1VSTy9L1otiEDE1df 92MQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=gzjIpPTE0BOMS+w0TJyJ1YeBbYxcBd9ssbvwpStcd2Y=; b=M2P45nIgphHaIvUWSKuZD4Mq2t2U1OBDG8c6JhHzyPOY4MI6pglGyI6S/Xxp8xbrdk GkINWNMJznT9bj5YzyqTm3NqUPEnjTiG8dPWoqOs9pt9ef6fLeONpA34dpXdCqBbodr9 YKQiF63pX3blyjySw+HmsrEBaVSg7npepG1F128W2N8ZnC6hUHdRMZ1W6/ZzToqXLIGr ns0LB6JwP80OOPn8IeXhIcEmzF62H8yA57K0NLxJNP/oiJ7/XlGkR1307OfMLqtl4RUf faMSY8e8II8F/Yz9pMt0sNbP61oaN7rnSxp52sRo6cKYbWVM2gSCxQurPSA1WcYNkbvy IgXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=STIqoXPB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ci27si15589152ejc.179.2020.07.22.04.28.39; Wed, 22 Jul 2020 04:29:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=casper.20170209 header.b=STIqoXPB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726841AbgGVL1r (ORCPT + 99 others); Wed, 22 Jul 2020 07:27:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726028AbgGVL1r (ORCPT ); Wed, 22 Jul 2020 07:27:47 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DABF3C0619DC for ; Wed, 22 Jul 2020 04:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gzjIpPTE0BOMS+w0TJyJ1YeBbYxcBd9ssbvwpStcd2Y=; b=STIqoXPBQrh67Rq3RQ2a3HH1Gz vMo8BeblxQGh2iST1cDC83ADsBLlr3xiRZCjKXMNAX92u0n3ssD72DAz/ssd5dJNLW0XK0VPGSunn iqurWIoRNfM1jCVFHWpjCEub3LDY50gAt9YlH/tk/9bHFzJizIXw+5icxqyjAs1O5FydgbOwXOvQJ oYDlawn1aaKXnSDcaxJ1jm3qAe4hx57G4cMOnMf9DPjqkTtM7QYd85V0713584BP3v8jn4CK7+Sps bkGNeMaGwQLoVpfHSy0z0QauBL5Y3CNq3Oojxc8ON4DbjCb1wWqm56SQq8dgOUJ83xT853upRlrjY BIbMacUg==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jyCuR-0005Ao-1m; Wed, 22 Jul 2020 11:27:40 +0000 Date: Wed, 22 Jul 2020 12:27:38 +0100 From: Matthew Wilcox To: qiang.zhang@windriver.com Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/dmapool.c: add lock protect in dma_pool_destroy Message-ID: <20200722112738.GN15516@casper.infradead.org> References: <20200722090516.28829-1-qiang.zhang@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200722090516.28829-1-qiang.zhang@windriver.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 22, 2020 at 05:05:16PM +0800, qiang.zhang@windriver.com wrote: > When traversing "pool->page" linked list, to prevent possible > other path operations this list, causing it to be destroyed, we > should add lock protect for this list in dma_pool_destroy func. The pool is being destroyed. If somebody else is trying to allocate from it while it's in the middle of being destroyed, there is a larger problem to solve, and it can't be solved in the dmapool code.