Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp485957ybh; Wed, 22 Jul 2020 05:47:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJws+oD0aAQotJlXzc+KSrLNtKfgXW7KqO1WBWvFTfhqAozUtDba7Unk7oS6TEI/KWDeLpg2 X-Received: by 2002:a17:906:2f17:: with SMTP id v23mr29315087eji.343.1595422066163; Wed, 22 Jul 2020 05:47:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595422066; cv=none; d=google.com; s=arc-20160816; b=xND11LPuo3jqeR0gdIY/qPtcZnu0httW4uNbAGV2cPkm8hp5NgbD3GZSht7F+aEU+j V0JnSDtW9zlMdRKtwXIaqm1rRS7IeHLE0Ah9d8QFWyQPcH0sDYmYFJjJ97cZ8jDELxaP 1tCVKN0DyT4Q69T60XFvQUA7w69NEFGXzpzmaVgU8hlc0jppp2THe+Bjvoh6tff3cEUu nfniT1G8Ipu0lcROKgZFzlA5vt+y18iyX9nnn3Z8fuMioQW5d16KT3lHqmMFdPzlYYqK JjY7tjxx1mZRw8S/A4u2FfDD0RdA+URpbTo7eJ5s++aNboinyy26mq0t4Ursi7/KhEhb nG2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:in-reply-to:date:references :message-id:organization:from:subject:cc:to:dkim-signature; bh=TMwc7BGRAH4UXd6M43+Uicp5h4KfH7HOJGlypIEIzX0=; b=Ysk6daOCBnuxOG1EvZ52RI52/O6QtLTCRPz6cY2x0U4zYBG082UVzZT0h3oRFmKPTI UGWQsZALh16jrVVKNwJ0jSZGmOemcLMP5GJ0cVQ+al3JjYEfBkOKWuPTRB9Hj0HQ22z3 T2UZ6KuflMSqX5O2bDqrWFIz6K7U4bQRg6DMPyP5QRpV/wNgCnef3kJrIEaynt7iw69u JIica6xeArUswqZ7/WJyJVXYP0UJJOfeGOIslEil9GYLV7/4ICpFfStRpbG/XTmd67IF caL46AXcebS6u/qzFhrh9Cip4liI0sQqPmYrrAvw/dVzuI292HUOU0gYjRbgfVeX3ZqW 5jLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=JuNcAjzl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d20si14558570edy.505.2020.07.22.05.47.22; Wed, 22 Jul 2020 05:47:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=JuNcAjzl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728642AbgGVMrE (ORCPT + 99 others); Wed, 22 Jul 2020 08:47:04 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:33536 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbgGVMrE (ORCPT ); Wed, 22 Jul 2020 08:47:04 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06MCVYxW015144; Wed, 22 Jul 2020 12:46:48 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : message-id : references : date : in-reply-to : mime-version : content-type; s=corp-2020-01-29; bh=TMwc7BGRAH4UXd6M43+Uicp5h4KfH7HOJGlypIEIzX0=; b=JuNcAjzlmL596wb9P1bqu0R42HNl1ikC7YCzopRH0jYf5QfpVKNWi+SmnmqaGyQb0beY yz6Spti13GXea3RufhIBjuBk9SifaR3wChgAYnR4Ym0K4me9Tw49X+5Mvock4QSmQ91T KIRc2xyWlW713Zc+4GQLYZOjT5ncu50ceddOxwlcR9fuws+L8xdyFzvfJ2r1jvmN0AE/ HrPvzi6bemjaUAA+N3DfqjZ0BLke5xq1t94Nljjc8E+h1RnbzqC/8XoydjkSZcT51VLF +u46n+6tBiIeyXEKZhGtynMtbOwElgrFIwneBhcuYkfjNLScFYGLw+9y7lkf5z7AURPD NQ== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 32d6ksq8jy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Jul 2020 12:46:48 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06MChYMw125098; Wed, 22 Jul 2020 12:46:48 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 32ehx0ddpj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 22 Jul 2020 12:46:48 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 06MCkgJY001307; Wed, 22 Jul 2020 12:46:43 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 22 Jul 2020 05:46:42 -0700 To: Christoph Hellwig Cc: Daejun Park , "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "asutoshd@codeaurora.org" , "beanhuo@micron.com" , "stanley.chu@mediatek.com" , "cang@codeaurora.org" , "bvanassche@acm.org" , "tomas.winkler@intel.com" , ALIM AKHTAR , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sang-yoon Oh , Sung-Jun Park , yongmyung lee , Jinyoung CHOI , Adel Choi , BoRam Shin Subject: Re: [PATCH v6 2/5] scsi: ufs: Add UFS-feature layer From: "Martin K. Petersen" Organization: Oracle Corporation Message-ID: References: <231786897.01594636801601.JavaMail.epsvc@epcpadp1> <963815509.21594636682161.JavaMail.epsvc@epcpadp2> <231786897.01594637401708.JavaMail.epsvc@epcpadp1> <20200722064112.GB21117@infradead.org> Date: Wed, 22 Jul 2020 08:46:38 -0400 In-Reply-To: <20200722064112.GB21117@infradead.org> (Christoph Hellwig's message of "Wed, 22 Jul 2020 07:41:12 +0100") MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9689 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 mlxlogscore=786 adultscore=0 phishscore=0 bulkscore=0 spamscore=0 suspectscore=1 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007220094 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9689 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=1 bulkscore=0 mlxscore=0 mlxlogscore=776 impostorscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007220094 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph, > Independent of the problems with the concept of HPB, this patch is > just really bad software architecture. Don't just add random > indirection layers that do represent an actual real abstraction. I am also not sold on the whole "bus" thing. -- Martin K. Petersen Oracle Linux Engineering