Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: vKcfbB8DomslsmFiGL4cyEBIZ/zBbPJx21GDs4qZ/5C7ojrLgWnPX1SMXsIr8lp6Ae7k7uko7P
 mGHCDk+VQ8JA==
IronPort-SDR: WJ6Qj/418nndmgvTB7pOtlXgYvSgyd0ICYRCcwjMwtaIgUxGQqn1lG/yysCIb6REj67T+kL8Lv
 LdsUNmnxECkg==
Subject: Re: [PATCH v12 05/15] perf evlist: implement control command handling
 functions
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Andi Kleen <ak@linux.intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <8d91c3a0-3db4-0a7a-ae13-299adb444bd6@linux.intel.com>
 <62518ceb-1cc9-2aba-593b-55408d07c1bf@linux.intel.com>
 <20200722122734.GJ77866@kernel.org> <20200722123423.GK77866@kernel.org>
From:   Alexey Budankov <alexey.budankov@linux.intel.com>
Organization: Intel Corp.
Message-ID: <cc1e7d3d-32ad-693f-6db6-4573ad49cb20@linux.intel.com>
Date:   Wed, 22 Jul 2020 15:45:43 +0300
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200722123423.GK77866@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 22.07.2020 15:34, Arnaldo Carvalho de Melo wrote:
> Em Wed, Jul 22, 2020 at 09:27:34AM -0300, Arnaldo Carvalho de Melo escreveu:
>> Em Fri, Jul 17, 2020 at 10:01:33AM +0300, Alexey Budankov escreveu:
>>>
>>> Implement functions of initialization, finalization and processing
>>> of control command messages coming from control file descriptors.
>>> Allocate control file descriptor as descriptor at struct pollfd
>>> object of evsel_list for atomic poll() operation.
>>>
>>> Signed-off-by: Alexey Budankov <alexey.budankov@linux.intel.com>
>>> Acked-by: Jiri Olsa <jolsa@redhat.com>
>>> Acked-by: Namhyung Kim <namhyung@kernel.org>
>>
>> I'm applying locally for testing, but can you answer what is the reason
>> for that newline in the CMD_ACK_TAG? I tried looking at previous
>> discussion but couldn't quickly find any reasoning for that
>>
>> - Arnaldo
>>
>>> +++ b/tools/perf/util/evlist.h
>>> @@ -359,4 +359,22 @@ void perf_evlist__force_leader(struct evlist *evlist);
>>>  struct evsel *perf_evlist__reset_weak_group(struct evlist *evlist,
>>>  						 struct evsel *evsel,
>>>  						bool close);
>>> +#define EVLIST_CTL_CMD_ENABLE_TAG  "enable"
>>> +#define EVLIST_CTL_CMD_DISABLE_TAG "disable"
>>> +#define EVLIST_CTL_CMD_ACK_TAG     "ack\n"
>>
>> What for? That '\n'?
> 
> Oh, I see, this is not a _command_, it is a _response_, and the sender
> expects a newline, right?

Right. Shell commands can expect strings terminated by \n, e.g. 'read -u'.
See sample bash script in 00/15 for example.

> 
> So I think this needs to be marked clearly as:
> 
> // Commands accepted by 'perf record'
> 
> #define EVLIST_CTL_CMD_ENABLE_TAG  "enable"
> #define EVLIST_CTL_CMD_DISABLE_TAG "disable"
> 
> 
> // Responses sent by 'perf record'
> 
> #define EVLIST_CTL_RSP_ACK     "ack"
> 
> And then make the response add the newline, as conceivably we could have
> something like "nack", "invalid", "enoperm", etc, no?

That above makes sense.

> 
> Anyway, this can be done on top of this series, so I'm continuing
> processing it locally.
> 
> - Arnaldo
> 

Alexei