Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 22 Jul 2020 22:05:27 +0800
From:   Dejin Zheng <zhengdejin5@gmail.com>
To:     Heiko =?utf-8?Q?St=C3=BCbner?= <heiko@sntech.de>
Cc:     corbet@lwn.net, gregkh@linuxfoundation.org, rafael@kernel.org,
        f.fainelli@gmail.com, linux-doc@vger.kernel.org,
        linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
        Michal Simek <michal.simek@xilinx.com>,
        Wolfram Sang <wsa@the-dreams.de>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v4 2/2] i2c: busses: convert to
 devm_platform_request_irq()
Message-ID: <20200722140527.GB8725@nuc8i5>
References: <20200717161158.11516-1-zhengdejin5@gmail.com>
 <3228833.Xz71LAOI96@diego>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3228833.Xz71LAOI96@diego>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jul 17, 2020 at 09:11:52PM +0200, Heiko Stübner wrote:
> Am Freitag, 17. Juli 2020, 18:11:58 CEST schrieb Dejin Zheng:
> > Use devm_platform_request_irq() to simplify code, and it contains
> > platform_get_irq() and devm_request_irq().
> > 
> > Cc: Michal Simek <michal.simek@xilinx.com>
> > Cc: Wolfram Sang <wsa@the-dreams.de>
> > Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
> > Acked-by: Linus Walleij <linus.walleij@linaro.org>
> > Acked-by: Michal Simek <michal.simek@xilinx.com>
> 
> 
> Rockchip part (i2c-rk3x):
> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
>
Heiko, Thanks a lot.

BR,
Dejin
> > diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> > index 8e3cc85d1921..1f0ac69c5774 100644
> > --- a/drivers/i2c/busses/i2c-rk3x.c
> > +++ b/drivers/i2c/busses/i2c-rk3x.c
> > @@ -1227,7 +1227,6 @@ static int rk3x_i2c_probe(struct platform_device *pdev)
> >  	int ret = 0;
> >  	int bus_nr;
> >  	u32 value;
> > -	int irq;
> >  	unsigned long clk_rate;
> >  
> >  	i2c = devm_kzalloc(&pdev->dev, sizeof(struct rk3x_i2c), GFP_KERNEL);
> > @@ -1289,17 +1288,10 @@ static int rk3x_i2c_probe(struct platform_device *pdev)
> >  		}
> >  	}
> >  
> > -	/* IRQ setup */
> > -	irq = platform_get_irq(pdev, 0);
> > -	if (irq < 0)
> > -		return irq;
> > -
> > -	ret = devm_request_irq(&pdev->dev, irq, rk3x_i2c_irq,
> > -			       0, dev_name(&pdev->dev), i2c);
> > -	if (ret < 0) {
> > -		dev_err(&pdev->dev, "cannot request IRQ\n");
> > +	ret = devm_platform_request_irq(pdev, 0, NULL, rk3x_i2c_irq,
> > +					0, dev_name(&pdev->dev), i2c);
> > +	if (ret < 0)
> >  		return ret;
> > -	}
> >  
> >  	platform_set_drvdata(pdev, i2c);
> >  
> 
> 
> 
>