Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp546840ybh; Wed, 22 Jul 2020 07:16:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzeH3l6sqL5nbPWGXTRAcgKUh81m2QEcHxwIDPCRK/TmJZGzm+IYEpTtVhsTD8Ly8nupxB0 X-Received: by 2002:a05:6402:b4c:: with SMTP id bx12mr29906436edb.157.1595427390645; Wed, 22 Jul 2020 07:16:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595427390; cv=none; d=google.com; s=arc-20160816; b=Kuxn1iLuilXp/X+NefhjRmVr9aHqsU0F8iKxVlnzukJrUEp+8FxYNa8pCqWQiWw2pc Hbr2e/MZjIyISM6JfTUYPFqG6SuRExKP/5OMsoAnOu47fVS+kV6cv5qjsxnoEpLGN6ka vEylJwCas8qmKdAHmM6JxQC9Kxe65IrOt+FesFTqILcRgqz28zBwKVtg+DG4WmHVspGU MCS7pUDdi5dSQhxTNH+ooFcV/18x0M9jXRyKO4QmgT+F9EldAQzIdLTo4gpKlYhmHK4h aHQM0adUbHf7aaEsBfdwYIdvEd6LprwPvv6YZj9aOTwSa8Gu8eIki4OxWKCtgr5vP9JF 2cHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=KOAav/6JDryc+tdqDx98e12Kehvz5H6IGoR3PZiPc4k=; b=T5RhNS+6gTKrBnrupdqxr7bCjzo40w8mOYhe9nZ6OqoDrnlz14aJdPEuA+laR5ToFO n38IDIT8LvrV2rFVXYGw5+AQf3Gr/HeF8zjwrP9xI9C4sjhEEJOIu06VReMveFxn6W3r u8IdvSNj62a3u+n6NR5yAdlE6ZMLRAzyeApIBgm9hehl3x2ZMUkC+uBDNp7qxi+F9Pjn JtTKR2keGnAZKayj4ahw4zow43JIMuH+OvHVo6a9NK44FAWZXAHrPW4ANcDiq/L1M923 kvIm9C6oK6n39IhelFmj9tFfBkG9ErHgHLFzlbsr4jcI1WdIjh/mLZ8Qvlrih9HOsv+0 6J7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 88si85817edr.154.2020.07.22.07.16.07; Wed, 22 Jul 2020 07:16:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732277AbgGVOO4 (ORCPT + 99 others); Wed, 22 Jul 2020 10:14:56 -0400 Received: from 8bytes.org ([81.169.241.247]:58728 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726003AbgGVOO4 (ORCPT ); Wed, 22 Jul 2020 10:14:56 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 204A0367; Wed, 22 Jul 2020 16:14:55 +0200 (CEST) Date: Wed, 22 Jul 2020 16:14:53 +0200 From: Joerg Roedel To: Wei Yongjun Cc: Hulk Robot , Eric Auger , Tom Murphy , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] iommu: Make some functions static Message-ID: <20200722141453.GL27672@8bytes.org> References: <20200713142542.50294-1-weiyongjun1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200713142542.50294-1-weiyongjun1@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 13, 2020 at 10:25:42PM +0800, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/iommu/iommu.c:386:5: warning: > symbol 'iommu_insert_resv_region' was not declared. Should it be static? > drivers/iommu/iommu.c:2182:5: warning: > symbol '__iommu_map' was not declared. Should it be static? > > Those functions are not used outside of iommu.c, so mark them static. > > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/iommu/iommu.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks.