Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp575271ybh; Wed, 22 Jul 2020 07:57:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRpXGXxBz2p0RBb/Euu6c5Y7Q+mqeOh05F0raLvy1OLYlU0JasHBDNJAEgFCjV5DrxFw8e X-Received: by 2002:a50:c307:: with SMTP id a7mr29888524edb.279.1595429847084; Wed, 22 Jul 2020 07:57:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595429847; cv=none; d=google.com; s=arc-20160816; b=rcBkE0wF1moSdoH51aLEe10fj92yApTuh0VdRi/Z0yd5dNoZ2e3Brhjdq/FhnpMdlX B906+6HqBXHdSQWJth1ZTsIl9nI+LCMBoHIseYtcnpys2sV5hvPdxuv14fF/3beaJTfu BlVq6VwxkeZdh7CyqF1qitOkbKOiDjoxkWrSDd0FvXXaS6a/mArEuCEPFx7BQXvowTwi E0l1yoS3xDCBCQr0wI0a1sVbqYn9B7EIQIFQ7sjGsEY7sq8OmWzH4URgfM1RfnIkXTpI puJThQJtqFg2q+vdGDgdGs6XrjG/OlOfn52ZWLhnJnNU83JKfozU5xFzqs0qg4dGG+Tu dDKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject:dkim-signature; bh=6gVk//BUazCMtzlozAWa7nTU6Yu6g/1ZlLTzqK6oLIM=; b=dVb0SGpjXs5hAmjlEDvl91REbm9sNyPFBFmvJvDSOxh5WzllI8tEGuc1DfP4vdTN02 5sR98ExLIoCneGqTygFVeZyWlaibIdQ+amBPpoobTdl/VAZQQypB+RE5O5jLgesrArDk eJ3lhVHgqNPYpug5+M3E8/OWN19Vo3vKV8AJwFlNS7aOGAywG0hRqSG8YCrcsMpZmg/i 8D78E66W2dHoNFBZ5AadELkSmDdB+rxSOQnm4n4EFdh++lg8gqCvzqJVpsrTYItqq3hs R5YssExdcD3u25O0gFOZV8qesBaJsat4azGI203WJ2nHu/nL/HAQ4NymFQfjqqQQlBn9 quMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HfmMA8HN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ao1si141434ejc.575.2020.07.22.07.57.02; Wed, 22 Jul 2020 07:57:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HfmMA8HN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732624AbgGVO4t (ORCPT + 99 others); Wed, 22 Jul 2020 10:56:49 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:51762 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730465AbgGVO4t (ORCPT ); Wed, 22 Jul 2020 10:56:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595429808; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6gVk//BUazCMtzlozAWa7nTU6Yu6g/1ZlLTzqK6oLIM=; b=HfmMA8HNSLmec0QeKebqetb5KkjzgE0KJ/a2nq65bi/81hljQfUOWwoeYIh4Uu08/vIf5H nqBPil0FO7neiC7v1tTfvFPBgMIlAhYDlRFlD2T1ZTvxnavUlzmYGv9GhGY5FV6iOkIvfI tP/8E1eL87+mxubr0RfYLUSeKoMwI5U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-502-mG0EkZpuPlCR4i706fgDDw-1; Wed, 22 Jul 2020 10:56:43 -0400 X-MC-Unique: mG0EkZpuPlCR4i706fgDDw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0F40419253C2; Wed, 22 Jul 2020 14:56:42 +0000 (UTC) Received: from [10.10.114.255] (ovpn-114-255.rdu2.redhat.com [10.10.114.255]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B50615FC3B; Wed, 22 Jul 2020 14:56:40 +0000 (UTC) Subject: Re: [PATCH v4 00/10] Function Granular KASLR From: Joe Lawrence To: Kees Cook , Miroslav Benes Cc: Kristen Carlson Accardi , tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, arjan@linux.intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-hardening@lists.openwall.com, rick.p.edgecombe@intel.com, live-patching@vger.kernel.org References: <20200717170008.5949-1-kristen@linux.intel.com> <202007220738.72F26D2480@keescook> Message-ID: Date: Wed, 22 Jul 2020 10:56:39 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/22/20 10:51 AM, Joe Lawrence wrote: > On 7/22/20 10:39 AM, Kees Cook wrote: >> On Wed, Jul 22, 2020 at 11:27:30AM +0200, Miroslav Benes wrote: >>> Let me CC live-patching ML, because from a quick glance this is something >>> which could impact live patching code. At least it invalidates assumptions >>> which "sympos" is based on. >> >> In a quick skim, it looks like the symbol resolution is using >> kallsyms_on_each_symbol(), so I think this is safe? What's a good >> selftest for live-patching? >> > > Hi Kees, > > I don't think any of the in-tree tests currently exercise the > kallsyms/sympos end of livepatching. > On second thought, I mispoke.. The general livepatch code does use it: klp_init_object klp_init_object_loaded klp_find_object_symbol in which case any of the current kselftests should exercise that. % make -C tools/testing/selftests/livepatch run_tests -- Joe