Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp598725ybh; Wed, 22 Jul 2020 08:28:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPXj1Y07mcEKnQwnIBQ9kCMRcIi9lSQ1kTZ7mevfm47gK/VQlkh/aYndesUOuTadE7RTW/ X-Received: by 2002:a17:906:365a:: with SMTP id r26mr121963ejb.52.1595431705538; Wed, 22 Jul 2020 08:28:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595431705; cv=none; d=google.com; s=arc-20160816; b=nuFvKduOaZoJ73X0inRY1WpZxTj3IQR1e5x7A/r8tmSisSgtF8GuLKhQ7t9aNexYpJ AAmEMQFG91lzhoH8nLUCTguXqs6U/rUp1jSxtUEPQrftdwTafGqu/quGvM7/Xs9HG8P6 kwOlU4BQ7TdP12ZQtBrYfhnduN8b6WI9+x/+LnM70ouQtYaA0YH+sStayUmj9kRIIaQ4 dWsjAZ8LFP2F6lz4zgJW5C5m66VCUTylKekNy4Jj36mNa1KeTJQt97JMycRb/qVxJ5hz kbk9vvBz1AU9YBSpo8sKUe7Kt+Q6fPMqIpvQJCwIHh31EtRgXfod66+aRuiMfLimA8ys kmpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=BU5kao+UrN6qaCFLRvgX1CCWwHi4WqVglmjspXYq5Sk=; b=ouoEmSAOC1r1nIJ7raz/Y2O0Zo9hnKEUHZcAOO3TQAf+JVt1uy+03CfxwW2a1Vzs/M jcvLRFCDPlITyGRzafOWmG3eMxFbkJITkx4Ufda+4iZ1vRf7WdpIfiZWUI+xkdfT7Ox4 8aojBsUqxeZ+MLIoAJFbI8CBv5pzw4H425zciB4qvbnkJhFRawQ7qa/ol/YQ6zIt+sBM L8PoV42E717i6S573Tx1bb3dAhU45YZatUOiNc9Hlqfb/PsRCr38e/QjhzQsQsX79iYb txoj5g8XeaiBYTktMqeA1z/y5z/+F8zzu88Q+XKlouUYrxq0NU+e/2mLN3E6XhM/11mB 5qrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=EovH3Vlz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id op5si160467ejb.617.2020.07.22.08.28.02; Wed, 22 Jul 2020 08:28:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@networkplumber-org.20150623.gappssmtp.com header.s=20150623 header.b=EovH3Vlz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732842AbgGVP1v (ORCPT + 99 others); Wed, 22 Jul 2020 11:27:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730600AbgGVP1u (ORCPT ); Wed, 22 Jul 2020 11:27:50 -0400 Received: from mail-pf1-x442.google.com (mail-pf1-x442.google.com [IPv6:2607:f8b0:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC095C0619DC for ; Wed, 22 Jul 2020 08:27:50 -0700 (PDT) Received: by mail-pf1-x442.google.com with SMTP id t11so1450015pfq.11 for ; Wed, 22 Jul 2020 08:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BU5kao+UrN6qaCFLRvgX1CCWwHi4WqVglmjspXYq5Sk=; b=EovH3VlzCQtsuc+av4WNCxJUcxJwP7B12FigkxGwdbpkWBJSa3nFzmdyDHewZBUgf9 n9XAAbimkyD6gzI4ZP5yddnLgDay1H3s8JWoHuKzSxSnwrCDbkxcwIVY/juKY/c9O6eu /OJSCysVhxcaeiqedSqEFceKVfg/12GZLPjr8pz1XHtNHTXpeFGbtjZFu3+roMJb796i BBnMW3Am+YU+1yDNm3kWRfcRFBtPlDgDBFvjGBggj1IU6U2AeUKKCFIvvGVB0VJDmGAM OReaUOEwz/0BPPxzQZFG4OMdZ6z6W9/XcwI4LsFf0nnHHUL9iPyaLIxuLhiXMi9xOuXE S9fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BU5kao+UrN6qaCFLRvgX1CCWwHi4WqVglmjspXYq5Sk=; b=AOnauNt4oTdYkaeO7F3BdKBZ/411rhuaYQjA7H9Ho4V0Pu2pKlQcSaj6Oh8REgFfKm f3x03capdz0tVytwOr6N5DSOf1dTagiegL96x1iujXNrp2+IFk1enEWYPbds0KwT90jk 4L9R4V5HPrO5QW1BJs3dqElwPqSC1yc7FddWjbYfuXWZcWhRHau11BpIPcViOXLpBqlf 9hl50HrYkzUr0Ldc3KfPytb6nCFszyhDiq6B6pMUURAUpo4US/qpVYsspbYkHTWBM1mR 2d5PECqhxrfrgE661Yw8vcthw/6qAk2e9aGlWupJ45C35Z52JjSX+cGRlxDFoKDmNZro VTFw== X-Gm-Message-State: AOAM530bf7Q95k0gYBKHbcnzzlFYWnMtbupilQE6swmfNeufNfg3kXcf 5V3bPfciCUUWhGYr/ksOCvlI6+lo2o16PA== X-Received: by 2002:a63:8c4f:: with SMTP id q15mr317114pgn.373.1595431670305; Wed, 22 Jul 2020 08:27:50 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id h23sm173554pfo.166.2020.07.22.08.27.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2020 08:27:49 -0700 (PDT) Date: Wed, 22 Jul 2020 08:27:41 -0700 From: Stephen Hemminger To: David Miller Cc: wangxiongfeng2@huawei.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net-sysfs: add a newline when printing 'tx_timeout' by sysfs Message-ID: <20200722082741.1675d611@hermes.lan> In-Reply-To: <20200721.153632.1416164807029507588.davem@davemloft.net> References: <1595314977-57991-1-git-send-email-wangxiongfeng2@huawei.com> <20200721.153632.1416164807029507588.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jul 2020 15:36:32 -0700 (PDT) David Miller wrote: > From: Xiongfeng Wang > Date: Tue, 21 Jul 2020 15:02:57 +0800 > > > When I cat 'tx_timeout' by sysfs, it displays as follows. It's better to > > add a newline for easy reading. > > > > root@syzkaller:~# cat /sys/devices/virtual/net/lo/queues/tx-0/tx_timeout > > 0root@syzkaller:~# > > > > Signed-off-by: Xiongfeng Wang > > Applied, thank you. Could you add Fixes: ccf5ff69fbbd ("net: new counter for tx_timeout errors in sysfs") Cc: david.decotigny@google.com