Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] scsi: lpfc: Add dependency on CPU_FREQ
To:     Guenter Roeck <linux@roeck-us.net>,
        "Martin K . Petersen" <martin.petersen@oracle.com>
Cc:     "James E . J . Bottomley" <jejb@linux.ibm.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Dick Kennedy <dick.kennedy@broadcom.com>,
        James Smart <jsmart2021@gmail.com>
References: <20200722023027.36866-1-linux@roeck-us.net>
From:   James Smart <james.smart@broadcom.com>
Message-ID: <0829df21-26fd-b023-4728-42025fb2dc20@broadcom.com>
Date:   Wed, 22 Jul 2020 09:13:12 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200722023027.36866-1-linux@roeck-us.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 7/21/2020 7:30 PM, Guenter Roeck wrote:
> Since commit 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for
> latency improvment"), the lpfc driver depends on CPUFREQ. Without it,
> builds fail with
>
> drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_init_idle_stat_hb':
> drivers/scsi/lpfc/lpfc_sli.c:7329:26: error:
> 	implicit declaration of function 'get_cpu_idle_time'
>
> Add the missing dependency.
>
> Fixes: 317aeb83c92b ("scsi: lpfc: Add blk_io_poll support for latency improvment")
> Cc: Dick Kennedy <dick.kennedy@broadcom.com>
> Cc: James Smart <jsmart2021@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>   drivers/scsi/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 571473a58f98..701b61ec76ee 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -1154,6 +1154,7 @@ source "drivers/scsi/qedf/Kconfig"
>   config SCSI_LPFC
>   	tristate "Emulex LightPulse Fibre Channel Support"
>   	depends on PCI && SCSI
> +	depends on CPU_FREQ
>   	depends on SCSI_FC_ATTRS
>   	depends on NVME_TARGET_FC || NVME_TARGET_FC=n
>   	depends on NVME_FC || NVME_FC=n

Reviewed-by:  James Smart <james.smart@broadcom.com>

-- james