Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp706354ybh; Wed, 22 Jul 2020 11:03:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYx9VaDjPEvYgWiUicyaYGy0Z1f7lB6paxTr4t3BhiPFIBjJu58CgPgy4UReqQmiyOBPei X-Received: by 2002:a17:906:1414:: with SMTP id p20mr711611ejc.247.1595441017889; Wed, 22 Jul 2020 11:03:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595441017; cv=none; d=google.com; s=arc-20160816; b=ReIVKC1AHYlw0znf3VK547HgO1n5AXci/PqtRprO6DMyZF5j7gzcai6NhsgJI2pbUk MlSF/eLSvamMwtPheIGrGYCJbT8pA07GeJHYXpKJW4uagZOvTm38X+GbTNfoBfB4+cgI 1L5DDVX8XA42q9vC0vDTGJ234mg/k5UpAgb+9MEPVmEamztZEgkuGsFBTwcR3PBlq2GC 7p11kad2BQxVjXJR7cb79YzLXuxkJ0LExD51DicRFJfYxEzpqjRf/gn9FAr6i+gnjBA6 HGTA0kqUr+uVn8dX9Vhy9GW8j3XLXCGbu4Oj4KHQBxV43m9iBTlDeltSVF843K+TrJK3 fbcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:cc:to:from:date:subject:ironport-sdr :dkim-signature; bh=7S9G0j6WNk2lHQ1bZXQAcCjIdbziJxspgdHUPMMA6gA=; b=QQgNfe4xIMU6kKxIHAtni1Mni2s+d6JHp7w/WeaIboTkF/XoDrNGjHxNDw8IgjvDUd NHT33MgyiAHCYb8aRfCLhmEXEsKcIk6OgSO2n5nqoWx1EqVLYjfFTG90MC9aS4Pdppm7 bmD6cClyw9F6AFIi9Ne5RCI8LlRMb5wzYaSSDuVh9tUnCABtI2MEgxU4O/RUpIuggaXe D81gyYFwJ/gaRgM5eY9RzeyaLre748EKoUXALWuiS994iqxRTHIaoeZ8N0yoxJAGcB7J IjuyB48sFSSimE5zuY7pmB1CSH+wk7pzG+6qWDPdhtYjmHsO4Dg/Oz5LiH2Jr84dokhi DnvA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=n3fKOZmR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn22si543751edb.477.2020.07.22.11.03.15; Wed, 22 Jul 2020 11:03:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.com header.s=amazon201209 header.b=n3fKOZmR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731165AbgGVSCw (ORCPT + 99 others); Wed, 22 Jul 2020 14:02:52 -0400 Received: from smtp-fw-33001.amazon.com ([207.171.190.10]:65397 "EHLO smtp-fw-33001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726390AbgGVSCw (ORCPT ); Wed, 22 Jul 2020 14:02:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1595440971; x=1626976971; h=date:from:to:cc:message-id:references:mime-version: content-transfer-encoding:in-reply-to:subject; bh=7S9G0j6WNk2lHQ1bZXQAcCjIdbziJxspgdHUPMMA6gA=; b=n3fKOZmRaWlxBxz8OeIFS/hlDM2E87OppNvfThGepfcaJqkjR7iQT9Dj dRT2IAFeAXGhT3jKEnn5cRRKjiWMcWmnPjGGG2AJ8a/nBplCMM1EvxDzO D/VBmBlpV94ZQ0ycDkUre0pLYhLg6dXIYwH3uZUaKisYOKOQ4IGRTHJKo I=; IronPort-SDR: gddspTBzn+Y+TFjJTeY9TdNlPFZ60AB2yNuYk5xuO/V+CC+LP+ZLXGVyt1ka9QWY+Qo+37Am9i sF1re8O1G5oQ== X-IronPort-AV: E=Sophos;i="5.75,383,1589241600"; d="scan'208";a="60802713" Subject: Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode Received: from sea32-co-svc-lb4-vlan3.sea.corp.amazon.com (HELO email-inbound-relay-1e-c7c08562.us-east-1.amazon.com) ([10.47.23.38]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 22 Jul 2020 18:02:46 +0000 Received: from EX13MTAUEB002.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1e-c7c08562.us-east-1.amazon.com (Postfix) with ESMTPS id 51994240ABB; Wed, 22 Jul 2020 18:02:40 +0000 (UTC) Received: from EX13D08UEB004.ant.amazon.com (10.43.60.142) by EX13MTAUEB002.ant.amazon.com (10.43.60.12) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Jul 2020 18:02:30 +0000 Received: from EX13MTAUEA001.ant.amazon.com (10.43.61.82) by EX13D08UEB004.ant.amazon.com (10.43.60.142) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 22 Jul 2020 18:02:29 +0000 Received: from dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (172.22.96.68) by mail-relay.amazon.com (10.43.61.243) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 22 Jul 2020 18:02:29 +0000 Received: by dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com (Postfix, from userid 4335130) id 8E7C44CA97; Wed, 22 Jul 2020 18:02:29 +0000 (UTC) Date: Wed, 22 Jul 2020 18:02:29 +0000 From: Anchal Agarwal To: Stefano Stabellini CC: Boris Ostrovsky , , , , , , , , , , , , , , , , , , , , , , , , , Message-ID: <20200722180229.GA32316@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> References: <20200702182136.GA3511@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <50298859-0d0e-6eb0-029b-30df2a4ecd63@oracle.com> <20200715204943.GB17938@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <0ca3c501-e69a-d2c9-a24c-f83afd4bdb8c@oracle.com> <20200717191009.GA3387@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <5464f384-d4b4-73f0-d39e-60ba9800d804@oracle.com> <20200721000348.GA19610@dev-dsk-anchalag-2a-9c2d1d96.us-west-2.amazon.com> <408d3ce9-2510-2950-d28d-fdfe8ee41a54@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 21, 2020 at 05:18:34PM -0700, Stefano Stabellini wrote: > CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe. > > > > On Tue, 21 Jul 2020, Boris Ostrovsky wrote: > > >>>>>> +static int xen_setup_pm_notifier(void) > > >>>>>> +{ > > >>>>>> + if (!xen_hvm_domain()) > > >>>>>> + return -ENODEV; > > >>>>>> > > >>>>>> I forgot --- what did we decide about non-x86 (i.e. ARM)? > > >>>>> It would be great to support that however, its out of > > >>>>> scope for this patch set. > > >>>>> I’ll be happy to discuss it separately. > > >>>> > > >>>> I wasn't implying that this *should* work on ARM but rather whether this > > >>>> will break ARM somehow (because xen_hvm_domain() is true there). > > >>>> > > >>>> > > >>> Ok makes sense. TBH, I haven't tested this part of code on ARM and the series > > >>> was only support x86 guests hibernation. > > >>> Moreover, this notifier is there to distinguish between 2 PM > > >>> events PM SUSPEND and PM hibernation. Now since we only care about PM > > >>> HIBERNATION I may just remove this code and rely on "SHUTDOWN_SUSPEND" state. > > >>> However, I may have to fix other patches in the series where this check may > > >>> appear and cater it only for x86 right? > > >> > > >> > > >> I don't know what would happen if ARM guest tries to handle hibernation > > >> callbacks. The only ones that you are introducing are in block and net > > >> fronts and that's arch-independent. > > >> > > >> > > >> You do add a bunch of x86-specific code though (syscore ops), would > > >> something similar be needed for ARM? > > >> > > >> > > > I don't expect this to work out of the box on ARM. To start with something > > > similar will be needed for ARM too. > > > We may still want to keep the driver code as-is. > > > > > > I understand the concern here wrt ARM, however, currently the support is only > > > proposed for x86 guests here and similar work could be carried out for ARM. > > > Also, if regular hibernation works correctly on arm, then all is needed is to > > > fix Xen side of things. > > > > > > I am not sure what could be done to achieve any assurances on arm side as far as > > > this series is concerned. > > Just to clarify: new features don't need to work on ARM or cause any > addition efforts to you to make them work on ARM. The patch series only > needs not to break existing code paths (on ARM and any other platforms). > It should also not make it overly difficult to implement the ARM side of > things (if there is one) at some point in the future. > > FYI drivers/xen/manage.c is compiled and working on ARM today, however > Xen suspend/resume is not supported. I don't know for sure if > guest-initiated hibernation works because I have not tested it. > > > > > If you are not sure what the effects are (or sure that it won't work) on > > ARM then I'd add IS_ENABLED(CONFIG_X86) check, i.e. > > > > > > if (!IS_ENABLED(CONFIG_X86) || !xen_hvm_domain()) > > return -ENODEV; > > That is a good principle to have and thanks for suggesting it. However, > in this specific case there is nothing in this patch that doesn't work > on ARM. From an ARM perspective I think we should enable it and > &xen_pm_notifier_block should be registered. > This question is for Boris, I think you we decided to get rid of the notifier in V3 as all we need to check is SHUTDOWN_SUSPEND state which sounds plausible to me. So this check may go away. It may still be needed for sycore_ops callbacks registration. > Given that all guests are HVM guests on ARM, it should work fine as is. > > > I gave a quick look at the rest of the series and everything looks fine > to me from an ARM perspective. I cannot imaging that the new freeze, > thaw, and restore callbacks for net and block are going to cause any > trouble on ARM. The two main x86-specific functions are > xen_syscore_suspend/resume and they look trivial to implement on ARM (in > the sense that they are likely going to look exactly the same.) > Yes but for now since things are not tested I will put this !IS_ENABLED(CONFIG_X86) on syscore_ops calls registration part just to be safe and not break anything. > > One question for Anchal: what's going to happen if you trigger a > hibernation, you have the new callbacks, but you are missing > xen_syscore_suspend/resume? > > Is it any worse than not having the new freeze, thaw and restore > callbacks at all and try to do a hibernation? If callbacks are not there, I don't expect hibernation to work correctly. These callbacks takes care of xen primitives like shared_info_page, grant table, sched clock, runstate time which are important to save the correct state of the guest and bring it back up. Other patches in the series, adds all the logic to these syscore callbacks. Freeze/thaw/restore are just there for at driver level. Thanks, Anchal