Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp740967ybh; Wed, 22 Jul 2020 11:58:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy4ej8VYLvr9GQQziKJDGCgXpJIZwvm9c+Mvmr1q5YCF2K2tJA7I4Fd6CborfFr7WBM6Alv X-Received: by 2002:a17:906:3b44:: with SMTP id h4mr1006492ejf.89.1595444285320; Wed, 22 Jul 2020 11:58:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595444285; cv=none; d=google.com; s=arc-20160816; b=iVbaZZ1JZPNReP/RQavu85gMbnDD7QnweNNdegLejQ9ReaVdbutkF7LehPQSw0hMuF CZI5+R1jeXNmqIpyebYxZgSuzpUP9QEo2FwcE1V5t/NeLXfGn4SfOng4gpJvPeIsquSu pUami/rj0vJy9e5JWMwOgkI5ge/0vkqeB8CTk/RRy3czHUFF+nwsdLl/QEyRBlGF6pQR XUpSlrbv/JSIUQe716isiXDcner4iI8lx3tztVmvnFezorG6pvIZNMkPPEsXdnY6bAoU 2HEzHCMZ2lNXhEumLeT9mwUKxAn0KCxUNYmnPWMiOlhfLNQqSXJi0rByk3lwIiy7Jqj2 WdZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=cyYqWjxKnaJnkrSinErf/w6JPEbLN4zqCCxlbnmFQcU=; b=A2AK8tdtL+UPB8R/neaYbivcvGus7MhxfHzdr173mTnkolVQbeDwPAVhiYvW8n3osE AWBJQll7wQUkQSQGoZWGJyZTX1YV9+umC4DgGeD28EGHyuY1HPUSVHz0j85bzDVOuN+T oKZhwX5EOP/kEmZK19koqaDDDKkLkYA9oeAd6xgt4kJ+rFYiiz6D142cloXIm62tuSvP s0p5DHaeU9SoMpy1By6WfbTerJKORpACGKUQ3jS8MV9eKmEwfTIv2EJt5BiPECU7ezSd 7WcIJVPY9Vmm+qC79y+fXOYdHj4JmrGgiLW1R591hu+5QPM/2Z2uZugBBfLgFmIy2NUM /jTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="AC+kH/cB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id df18si494157edb.501.2020.07.22.11.57.41; Wed, 22 Jul 2020 11:58:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="AC+kH/cB"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732321AbgGVS5c (ORCPT + 99 others); Wed, 22 Jul 2020 14:57:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726685AbgGVS5c (ORCPT ); Wed, 22 Jul 2020 14:57:32 -0400 Received: from mail-io1-xd42.google.com (mail-io1-xd42.google.com [IPv6:2607:f8b0:4864:20::d42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D40ACC0619DC; Wed, 22 Jul 2020 11:57:31 -0700 (PDT) Received: by mail-io1-xd42.google.com with SMTP id k23so3633403iom.10; Wed, 22 Jul 2020 11:57:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cyYqWjxKnaJnkrSinErf/w6JPEbLN4zqCCxlbnmFQcU=; b=AC+kH/cBHN2vxvPbFT/Fgh402oNBuH353UPFNnCxHWEKrs/jGKQ60beooblVSxtdeZ YkDqtRUWvzeHgv8OpqaSOb4kZJSxLzgT+u/luWaHIAXgvr/dOypo1t6OygyOfKEsCNJ2 7bzgXavlIboo6/4aTKak+orDkA3RHv2Y+AgaPDBLPBv2USv3p7XVRxR6nfztiR/p0mIL 3L5m40vDAnr/Et3RRG53e+vVAQCqbs8wx94As5GNARAhIoc8YqXEd2yr8DptSp+4O20j 0S9R+NPQ4bSueZ0gyIWGp82KADBwMJ6bdhxLp65/KBfEzFOhGUqdw1eI8g9yBmq5fEha WIyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cyYqWjxKnaJnkrSinErf/w6JPEbLN4zqCCxlbnmFQcU=; b=NRcLkJ32SCrFvUZ0/w6UwIoFdC2Z87CBkCZKaPbU8HzWU80PlmpHnKKhjSlwBrQSh1 VjgulnjhtLBmDvX++zmIehYRhHP14iKZj/co0jAwyKRRJZpxXw7yf0M85LocJZThyE9+ IUI2Ib/vM+i63jQPG3Lv/OXEMv36Vel6Fap6kwZVd6QCCTYV+OIjt6Idk8RJxB2m2s0s bobjObBipX2FhnhgqbY3poD19ymx1EwiHE11EXXEn5Ey4MJd/LpOUSqNMZVZpT7W03vC 05nIgnXE69pOxhYh5wxtmkT1jn19WS8FU8IsDVKc5wVpaawga9OyjcLbSR6CMb5BgFjh 8JMQ== X-Gm-Message-State: AOAM532u8ImBa31mNRh36QnF1f+SHRnasdNqFNabyqPKHPjvrGcICYXI xNWJ0Pc5rV+JZMgWymZZphI= X-Received: by 2002:a02:a408:: with SMTP id c8mr684723jal.59.1595444251225; Wed, 22 Jul 2020 11:57:31 -0700 (PDT) Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [160.94.145.20]) by smtp.googlemail.com with ESMTPSA id a5sm186256iol.39.2020.07.22.11.57.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2020 11:57:30 -0700 (PDT) From: Navid Emamdoost To: Vishal Kulkarni , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: emamd001@umn.edu, Navid Emamdoost Subject: [PATCH v2] cxgb4: add missing release on skb in uld_send() Date: Wed, 22 Jul 2020 13:57:21 -0500 Message-Id: <20200722185722.3580-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200720.183113.2100585349998522874.davem@davemloft.net> References: <20200720.183113.2100585349998522874.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the implementation of uld_send(), the skb is consumed on all execution paths except one. Release skb when returning NET_XMIT_DROP. Signed-off-by: Navid Emamdoost --- changes in v2: - using kfree_skb() based on David Miller suggestion. --- drivers/net/ethernet/chelsio/cxgb4/sge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/sge.c b/drivers/net/ethernet/chelsio/cxgb4/sge.c index d8c37fd4b808..92eee66cbc84 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/sge.c +++ b/drivers/net/ethernet/chelsio/cxgb4/sge.c @@ -2938,7 +2938,7 @@ static inline int uld_send(struct adapter *adap, struct sk_buff *skb, txq_info = adap->sge.uld_txq_info[tx_uld_type]; if (unlikely(!txq_info)) { WARN_ON(true); - consume_skb(skb); + kfree_skb(skb); return NET_XMIT_DROP; } -- 2.17.1