Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp770797ybh; Wed, 22 Jul 2020 12:47:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyaLqZX9FYl5oB0r7c17amjWVd241tTCsArIty4cMj4TbOhAacvPwGhTVOZrV2u/6fISKlg X-Received: by 2002:a05:6402:1ca6:: with SMTP id cz6mr959383edb.171.1595447272496; Wed, 22 Jul 2020 12:47:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595447272; cv=none; d=google.com; s=arc-20160816; b=rV1/A6IRir9SsS/wm87xEe7c70l5CnrDTrGYkkwGT1/9M+yS+/6Dwrm0zedoCZaiA8 4+jP8tSBlMFPsvbgnGy23jC2sTD6hZi3zy4XqUs0Mo0tUQJ0BxqXP6zc+kF9yY5RIqqp sBGCAnhMuzONN9MvPhxyO5rxAczU8+rL+YHljo/+ELFPPSoC3b4yc+J0XZ+iKgB5FkMf 3fwst6x0T/+tyuoykt4o2b9o1vd4DSF6zYLKIp0QEh43gHUSINS/5iOYmhLNHrg6NCtD tOVNlPidkEsU/KeRJbLTm6y/4dj0zdEvwxMu5ICxPWQcLvaEPFoxRi2mC0Efumxn1Tza MiLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=nWRg8habjmwUq/aSOIs5oJ/PIMDu1J2enCdaZpnqjtI=; b=bEt1O69X2YyuWATpt7Of17U1KFafgvjZEN9X99bMRkj2LgMs51CNMpLw2ERRakpnxk YRus7ix3sV/0sGK06lD9xWbE4CPkYkJ0tJQ+jUDalxM5h2IGP6lES9D6tMV5yXG0R9v4 nvnI+0sCdth4aA4wvMBAS0/ct6YxCf2/7eBjlnnIave7msj6o0KiTrDheRn0YCiLju8G Gi5Bqj8h5rC2kS7R3z7mruovmylm0heQ3pK2JWDCo1TKW3jlb7g99KcEZhbhR3KWZm3X xCj/zmfbLybSL+09bNXeyee5JFwLngbV3eeXHUKVGBJqMao5GL3FZ2VoroQT1FOdzvGq tS/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Rvheysi+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s25si604382ejv.413.2020.07.22.12.47.28; Wed, 22 Jul 2020 12:47:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Rvheysi+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726841AbgGVTpN (ORCPT + 99 others); Wed, 22 Jul 2020 15:45:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726157AbgGVTpN (ORCPT ); Wed, 22 Jul 2020 15:45:13 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDA95C0619DC for ; Wed, 22 Jul 2020 12:45:12 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id w17so1493697ply.11 for ; Wed, 22 Jul 2020 12:45:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=nWRg8habjmwUq/aSOIs5oJ/PIMDu1J2enCdaZpnqjtI=; b=Rvheysi+PYCBmuMOpzRtK6Oze6jqgkcolfrm0c2G06ZfucZ7GN0cNoCE00nMt2FymF bAeDzTaaaM7LEWiVN/ByX7unj0u0rupZmXTT/6dfvTS1tdTa5UQ1K1x+SZPtoxk/hjTq +c06od/fOU5c0Kj4Evbb/bGw1U4B0Ub2f8v6k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=nWRg8habjmwUq/aSOIs5oJ/PIMDu1J2enCdaZpnqjtI=; b=E8r2Grc+6tEw6U43XvyuZzyEtVjeogLKSmFTh8tTA9lh3+lXja172l4mGs25j+hhLF DPN5GRf2J0cM1iF1gt1qTi2Z9aLWX01qDmggSMrCL8ipVdPluN22RBmSRgEmCFXD8KLD JkC+jvd6SRL6jOu9m6gjfugGqPKSDBWFC35Yv5O/Omw4aGozAST4Wn6gWIvg8/0SPh5D rAumQycEDl8HQN1aCWR8xelmRQJLnW6tmPrvBrfZ5fR8ztjtR2hPYCyMljJEKNzQQPaS 9j+/Ey03bSTgeyWkK8YPcMsFiR/42gGu+dupYdRdESBuTeyZx6aITShsl4PNPbXthRuK R4WQ== X-Gm-Message-State: AOAM531rajImn31U5JIA5GFU++ZzAAhNtq4ec0GrK6lglnZqgEAMpYdo u/iSdZHSD0MKkFwRVO4v35a1Pg== X-Received: by 2002:a17:90a:a50d:: with SMTP id a13mr837453pjq.95.1595447112507; Wed, 22 Jul 2020 12:45:12 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id t29sm432106pfq.50.2020.07.22.12.45.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2020 12:45:11 -0700 (PDT) Date: Wed, 22 Jul 2020 12:45:10 -0700 From: Kees Cook To: Vitor Massaru Iha Cc: KUnit Development , "open list:KERNEL SELFTEST FRAMEWORK" , Linux Kernel Mailing List , Brendan Higgins , David Gow , Shuah Khan , linux-kernel-mentees@lists.linuxfoundation.org Subject: Re: [PATCH v3] lib: Convert test_user_copy to KUnit test Message-ID: <202007221244.4E3C9E45@keescook> References: <20200721174654.72132-1-vitor@massaru.org> <202007211207.5BAA9D8D@keescook> <202007211911.666E080@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 22, 2020 at 03:29:27PM -0300, Vitor Massaru Iha wrote: > On Tue, Jul 21, 2020 at 11:12 PM Kees Cook wrote: > > > > On Tue, Jul 21, 2020 at 07:19:12PM -0300, Vitor Massaru Iha wrote: > > > When you talk about end-of-test summary, is it what is written in > > > dmesg and not the kunit-tool? > > > > Right, if I build this as a module and do "modprobe user_copy_kunit", > > what will show up in dmesg? > > No, It doesn't. I'll put the messages again. Would it be possible to add that behavior to the core KUnit output? Then all module-based tests would include a summary line? -- Kees Cook