Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp779160ybh; Wed, 22 Jul 2020 13:03:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzBvRMiKU2e2kQVgzZ9pEF7qGJ3sr0epsuUkHeiaKZoKgtbsVfnA+b94KI44yrYRnszU1cA X-Received: by 2002:a17:906:1151:: with SMTP id i17mr1169783eja.535.1595448198179; Wed, 22 Jul 2020 13:03:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595448198; cv=none; d=google.com; s=arc-20160816; b=VNUbZJpt4g0ZuztJ6tNhJ7swx9NNBbDJovvWnonVqgEeYow35qxXuBu/A6eN9eVLnQ Dbj50k7usz8ue+D/lcsWPJgws+m81WupYwb3g03mergSjeW0UmebMu2uFpLEizTAFFbu FNSAp/JWziCE+y/c7N5FiTkCkk1cEc76qCiKqa+Sy9QTxfGClUugqhs1WhwyRa2Ghfrf LkUf3wwwNsrqNDC0NEQSeD/+sA7o9bkeWkMDEW9/wmCiROcmTFQqHMEnWUDt51nYRf7X NFxvznBUs6J/oqwG2NRksYkkLZfR2T67Qjsr9EmS4hrf8/zo2z03B+P+b7RgJEO+cj/W hhZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=DtfiNwjo/uflASTYv6Kx9HutRPH8lipQEv9TW1QGciU=; b=N5gPoSt3B4/OCoX4FeYopC2B++HEljr+IQhY192BozOKLrraBC8D/uVGClkGxcnfPw 1nEsFEp3jIEtmLLOo5i4JO8EM7ZiVnIORP1Xb/lqevUPc4voy5kXTM9uh2H2E2dzfuOf WSMGxZx4fUA9JHF7cpP3VnealB2nm+8oO/g9U6tcP7Js0XTh1H/E02chuVhq83og+ape YL1YLz7+x53N1SxEyzHMUyu9jtVt0haCd1FyQ6aDWmjn+3eNpbI+6n3m1NXskm9UldVM g0XGIykdqXQpiHlG70JITl0npbb6l2I2MFCM8ePB4pYBJ2NlybgkZ9BW5qtthqvDuGyD FeAQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q3si631219ejb.105.2020.07.22.13.02.55; Wed, 22 Jul 2020 13:03:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732772AbgGVT7y (ORCPT + 99 others); Wed, 22 Jul 2020 15:59:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726888AbgGVT7y (ORCPT ); Wed, 22 Jul 2020 15:59:54 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42592C0619DC; Wed, 22 Jul 2020 12:59:54 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EF56611FFC80E; Wed, 22 Jul 2020 12:43:07 -0700 (PDT) Date: Wed, 22 Jul 2020 12:59:52 -0700 (PDT) Message-Id: <20200722.125952.2002253965644109632.davem@davemloft.net> To: hongbo.wang@nxp.com Cc: xiaoliang.yang_1@nxp.com, allan.nielsen@microchip.com, po.liu@nxp.com, claudiu.manoil@nxp.com, alexandru.marginean@nxp.com, vladimir.oltean@nxp.com, leoyang.li@nxp.com, mingkai.hu@nxp.com, andrew@lunn.ch, f.fainelli@gmail.com, vivien.didelot@gmail.com, jiri@resnulli.us, idosch@idosch.org, kuba@kernel.org, vinicius.gomes@intel.com, nikolay@cumulusnetworks.com, roopa@cumulusnetworks.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horatiu.vultur@microchip.com, alexandre.belloni@bootlin.com, UNGLinuxDriver@microchip.com, linux-devel@linux.nxdi.nxp.com Subject: Re: [PATCH] net: dsa: ocelot: Add support for QinQ Operation From: David Miller In-Reply-To: <20200722055048.6129-1-hongbo.wang@nxp.com> References: <20200722055048.6129-1-hongbo.wang@nxp.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Jul 2020 12:43:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: hongbo.wang@nxp.com Date: Wed, 22 Jul 2020 13:50:48 +0800 > diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c > index c69d9592a2b7..12b46cb6549c 100644 > --- a/drivers/net/dsa/ocelot/felix.c > +++ b/drivers/net/dsa/ocelot/felix.c > @@ -132,9 +132,13 @@ static void felix_vlan_add(struct dsa_switch *ds, int port, > { > struct ocelot *ocelot = ds->priv; > u16 flags = vlan->flags; > + struct ocelot_port *ocelot_port = ocelot->ports[port]; > u16 vid; > int err; Please use reverse christmas tree ordering for local variables.