Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp790992ybh; Wed, 22 Jul 2020 13:24:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzw30bjaLJg2fDetI+MtJ6BUMvpt+//O86XhhIDo4h7cKH3tYotSQvFKGHorINAdLnzaWfI X-Received: by 2002:a17:906:7743:: with SMTP id o3mr1247477ejn.224.1595449474966; Wed, 22 Jul 2020 13:24:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595449474; cv=none; d=google.com; s=arc-20160816; b=uIuhTBJe4Nf4GqnTK02dX5DPe6vXoK6gFjgo/hilgHsNbbvrqzO6h1oGFrDIz79j5e Bq9S5AgmyHWrxUZV8Vch4+fOs/MiZ+hoecDDCjeOODgAVNcdacerAROrZ61LHs83tLHb Rwj+86zDoRZ25/W42D413E9ckVfeFvjuru1VFtcfe0fhMoRlWGekoLE54942qZxi0d1N WQbBIIfXXUBjoNGDGH6xkarPsoSJDbl9jEI1N6R+2S77whEEkE4YbqyWf6eengitTWxv kDuiBycGgwOIhfaScmqOez9NtJtZSoB66EYx9I3fa8RXPgvjU0eryQPAwuecCehMhuLK zJnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=2X35NxHCk5fdWmmmHUK1YaFmzBCJlOMQ1/kXN+QYV/4=; b=xN5jTSJonjsMEvn1i67of4AqbFjXHVHcWWniTJOdAnMUs1/wbYHTTlXDNXL9uP8pWA +GptufoLU5d5ZaGMFMC/omocQuX3qqQ8EMvqxX0Lqj/VgtdO5UykuQwAdT1iMEZMFzE7 gZQoquDdLUe3CoadB2HYB09zVclpd09O787gfV8YaqjETOfgE4ODnBfbhsel14P1zVIM uHX0fg11A93a1+o2XF0yY9IJfz90E4JNYy3eKZ+J1JF4cbSPymelzbsaTnzXTOpoZBzx nDPnHXG0aTpdEzllUduD7+W34igLS0Iv0GOEiEfIlQw/T9zRVfyKCLlTwR5A4sOHXNOc 2Jsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs10si641100edb.548.2020.07.22.13.24.12; Wed, 22 Jul 2020 13:24:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732710AbgGVUXM (ORCPT + 99 others); Wed, 22 Jul 2020 16:23:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726447AbgGVUXM (ORCPT ); Wed, 22 Jul 2020 16:23:12 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 693A1C0619DC; Wed, 22 Jul 2020 13:23:12 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 11FAB1210C0BE; Wed, 22 Jul 2020 13:06:27 -0700 (PDT) Date: Wed, 22 Jul 2020 13:23:11 -0700 (PDT) Message-Id: <20200722.132311.31388808811810422.davem@davemloft.net> To: stephen@networkplumber.org Cc: wangxiongfeng2@huawei.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net-sysfs: add a newline when printing 'tx_timeout' by sysfs From: David Miller In-Reply-To: <20200722082741.1675d611@hermes.lan> References: <1595314977-57991-1-git-send-email-wangxiongfeng2@huawei.com> <20200721.153632.1416164807029507588.davem@davemloft.net> <20200722082741.1675d611@hermes.lan> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Jul 2020 13:06:27 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Hemminger Date: Wed, 22 Jul 2020 08:27:41 -0700 > On Tue, 21 Jul 2020 15:36:32 -0700 (PDT) > David Miller wrote: > >> From: Xiongfeng Wang >> Date: Tue, 21 Jul 2020 15:02:57 +0800 >> >> > When I cat 'tx_timeout' by sysfs, it displays as follows. It's better to >> > add a newline for easy reading. >> > >> > root@syzkaller:~# cat /sys/devices/virtual/net/lo/queues/tx-0/tx_timeout >> > 0root@syzkaller:~# >> > >> > Signed-off-by: Xiongfeng Wang >> >> Applied, thank you. > > Could you add Stephen, of all people you should know by now that all of my commits are %100 immutable. So commit log changes cannot be made after I've applied the patch, ever.