Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <bug-208655-6666@https.bugzilla.kernel.org/> <87h7tz306w.fsf@nanos.tec.linutronix.de>
 <CAMe9rOrER7Mg_YvzuqguS-GCyP-bD2hogWeo+OMXm7F6JXQUDQ@mail.gmail.com> <87r1t3z612.fsf@nanos.tec.linutronix.de>
In-Reply-To: <87r1t3z612.fsf@nanos.tec.linutronix.de>
From:   "H.J. Lu" <hjl.tools@gmail.com>
Date:   Wed, 22 Jul 2020 14:22:17 -0700
Message-ID: <CAMe9rOoXQK5GgveVem2fSJWeAYUDjoKOo6ESpkU+29NfytNC7A@mail.gmail.com>
Subject: Re: [PATCH] x86/dumpstack: Dump user space code correctly again
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Christoph Hellwig <hch@lst.de>,
        Josh Poimboeuf <jpoimboe@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jul 22, 2020 at 12:47 PM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> "H.J. Lu" <hjl.tools@gmail.com> writes:
> > On Wed, Jul 22, 2020 at 10:54 AM Thomas Gleixner <tglx@linutronix.de> wrote:
> >> +       if (copy_code(regs, opcodes, prologue, sizeof(opcodes))) {
> >>                 printk("%sCode: Bad RIP value.\n", loglvl);
> >>         } else {
> >>                 printk("%sCode: %" __stringify(PROLOGUE_SIZE) "ph <%02x> %"
> >
> > Add a kerel self test?
>
> Care to whip one up?
>

Can we count "dmesg" to always dump opcode?

-- 
H.J.