Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp901422ybh; Wed, 22 Jul 2020 16:43:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJylsH5f+MFbUuGecchPIaOPU9PZpR5d0rrjMoaw9VWtD76OtifSZg1wIeGx+rIP7OQyH4Xi X-Received: by 2002:a05:6402:1c0f:: with SMTP id ck15mr1649939edb.155.1595461379903; Wed, 22 Jul 2020 16:42:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595461379; cv=none; d=google.com; s=arc-20160816; b=vPQ2X1VxRHbcoPhM88iTW41lTZQrfdZVDl86ALpxA7A+OtrToUQPPs6RJuppaDYvyS ex3EH7gD1XApaLzjcEfKkfl7In6WAymZv+Uidal53dOqJLcwygo6PUILqO201JA2s4Zk i+x9zOEAOfg4+WfRn53OQ22qceKBSOFNSM0dNqxkHKl6KuqwMZZEsWbPvDNUA+rzMT/l CO9bkdA3Afqju0NoNFMX/Q0VXcdFQGZSGmzldZ3vbBidjcmvvpqHCT7KgA8wIGbujHdh BE57sbd97gpdMkwMAZYWFZeZaYIHgAlYbXtqFdqUwQn6Hs1yuzzc/gClv7MAFEcFdHLE ylzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature:dkim-filter; bh=8nFQ2Lcsut3ehCNONJCifbSUqk3XtP90FAvfPGV5V8M=; b=fEbuIz+9cwJz7IbojUqfzewzVKHb8MxpFfmFfYdhGvtd9IlH1VTkUEofAlI19P+B3L /dnkX0ZYPIeoklGVRdJZESXSHy/ti50ptNICFZbpwsLmrCrFrQc4Ey6HTqXkjt0uW2SM gHN1pOol4522Ykqh3LotWyuEXZTkYdbjk2w2p0pMC04Tp06x3n4dijF3fGp4f+Y+Ak2l IoYfF4wk+sLjX8bmbd8MZ87UxticNVoJBNsowkH/QvPFP0nxUVy/NGuzKOEVcelmFMzJ k8Rn+7MtzHA3sJ/y3Sbm5ee5cPs2JXUJY+UXCGysW95rrpmZe5pjfaCiQYKpdg8kI6H4 jxUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=sUkVovD5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do14si1149227ejc.39.2020.07.22.16.42.36; Wed, 22 Jul 2020 16:42:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.microsoft.com header.s=default header.b=sUkVovD5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.microsoft.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730258AbgGVXmb (ORCPT + 99 others); Wed, 22 Jul 2020 19:42:31 -0400 Received: from linux.microsoft.com ([13.77.154.182]:48522 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726685AbgGVXmb (ORCPT ); Wed, 22 Jul 2020 19:42:31 -0400 Received: by linux.microsoft.com (Postfix, from userid 1070) id 3850520B4908; Wed, 22 Jul 2020 16:42:30 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3850520B4908 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1595461350; bh=8nFQ2Lcsut3ehCNONJCifbSUqk3XtP90FAvfPGV5V8M=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=sUkVovD5JtN3wMWJ9+zyQkFggOHc3SD7UuQcLlEiOuw6g827SaoLx597VeqeeDNZQ ZBjooW8odcJ89N/QoqTmJAoLcFN4j5lw8HNR8xtTeCH+cBQc6vQRzYUXsB3JL3QV8Y lmRY29tSV4LDlRjcFc/ltBQA+E/F7ArRkbMhR71c= Received: from localhost (localhost [127.0.0.1]) by linux.microsoft.com (Postfix) with ESMTP id 33D97307032D; Wed, 22 Jul 2020 16:42:30 -0700 (PDT) Date: Wed, 22 Jul 2020 16:42:30 -0700 (PDT) From: Chi Song X-X-Sender: chisong@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net To: Florian Fainelli cc: Jakub Kicinski , Chi Song , Stephen Hemminger , David Miller , Haiyang Zhang , KY Srinivasan , Stephen Hemminger , "wei.liu@kernel.org" , "linux-hyperv@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v6 net-next] net: hyperv: Add attributes to show TX indirection table In-Reply-To: <78ca93f5-bb3f-96f9-17c5-3c1855b11a40@gmail.com> Message-ID: References: <20200721122127.3ce422f3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <78ca93f5-bb3f-96f9-17c5-3c1855b11a40@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Jul 2020, Florian Fainelli wrote: > On 7/21/20 12:21 PM, Jakub Kicinski wrote: > > On Tue, 21 Jul 2020 04:58:59 +0000 Chi Song wrote: > >> An imbalanced TX indirection table causes netvsc to have low > >> performance. This table is created and managed during runtime. To help > >> better diagnose performance issues caused by imbalanced tables, add > >> device attributes to show the content of TX indirection tables. > >> > >> Signed-off-by: Chi Song > > > > Sorry for waiting until v6 but sysfs feel like a very strange place to > > expose this. Especially under the netdev, not the bus device. > > > > This looks like device specific state, perhaps ethtool -d is a more > > appropriate place? > > Agreed, or a devlink resource maybe? Thank you for comments, I will move it to ethtool.