From: Ingo Oeser <ioe-lkml@rameria.de>
To: Christoph Hellwig <hch@infradead.org>
Subject: Re: [RFC PATCH 03/35] Add Xen interface header files
Date: Wed, 10 May 2006 00:36:00 +0200
User-Agent: KMail/1.9.1
Cc: Chris Wright <chrisw@sous-sol.org>, linux-kernel@vger.kernel.org,
       virtualization@lists.osdl.org, xen-devel@lists.xensource.com,
       Ian Pratt <ian.pratt@xensource.com>,
       Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
References: <20060509084945.373541000@sous-sol.org> <20060509085147.903310000@sous-sol.org> <20060509151516.GA16332@infradead.org>
In-Reply-To: <20060509151516.GA16332@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200605100036.02776.ioe-lkml@rameria.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 978
Lines: 32

Hi Christoph,

On Tuesday, 9. May 2006 17:15, Christoph Hellwig wrote:
> > Signed-off-by: Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
> > Signed-off-by: Chris Wright <chrisw@sous-sol.org>
> > ---
> >  include/xen/interface/arch-x86_32.h   |  197 +++++++++++++++
> 
> that kind of stuff needs to go to asm/
> 
> >  include/xen/interface/event_channel.h |  205 +++++++++++++++
> 
> instead of interface please use something shorter, we'll see this
> all over the includes statements.  intf for example.

I like them and think they are quite clear.

Documentation/CodingStyle Chapter 4: Naming
seem to apply here.

And since you type the include only ONCE per file,
this looks like a good trade, doesn't it?


Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/