Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbWEIWmG (ORCPT ); Tue, 9 May 2006 18:42:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751331AbWEIWmG (ORCPT ); Tue, 9 May 2006 18:42:06 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:5392 "EHLO arnor.apana.org.au") by vger.kernel.org with ESMTP id S1751327AbWEIWmF (ORCPT ); Tue, 9 May 2006 18:42:05 -0400 From: Herbert Xu To: chrisw@sous-sol.org (Chris Wright) Subject: Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver. Cc: linux-kernel@vger.kernel.org, virtualization@lists.osdl.org, Christian.Limpach@cl.cam.ac.uk, xen-devel@lists.xensource.com, netdev@vger.kernel.org, ian.pratt@xensource.com Organization: Core In-Reply-To: <20060509085201.446830000@sous-sol.org> X-Newsgroups: apana.lists.os.linux.kernel,apana.lists.os.linux.netdev,apana.lists.os.xen.devel User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686)) Message-Id: Date: Wed, 10 May 2006 08:41:29 +1000 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 690 Lines: 18 Chris Wright wrote: > > + netdev->features = NETIF_F_IP_CSUM; Any reason why IP_CSUM was chosen instead of HW_CSUM? Doing the latter would seem to be in fact easier for a virtual driver, no? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/