Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp950006ybh; Wed, 22 Jul 2020 18:15:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoVpchoTT5n4v2UOViv13VNM8Ul120HOvCfMrlJteYQe50IbiL1OktW9xYtWJn5MY45FN2 X-Received: by 2002:a17:906:e294:: with SMTP id gg20mr2007622ejb.521.1595466904592; Wed, 22 Jul 2020 18:15:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595466904; cv=none; d=google.com; s=arc-20160816; b=e4hwvacH6a7UswhTa3h0nI1tgBRes2X/XxsirnePbNWeAyvEtjOoPQHAHeNzPhZQ3l dd4Dyo8O1iiBB5kojvT9943H5cF7XvvQHJPzikXkrmzjvzeJdgXW2G4AnHpEKwzB8X0k rcC2q9vYAa4mWrZho3nK5vtH8n/LG2ymzXKrennjtSg49aGCWdj/BVKruuFl9bQsEIXN 6PQcX8AbU39Es+FNjYaWy+mEfOrUdJ1TIwjPLHVSZKTretTuGufyh2RiL8k204YzC+Sr xkUGGFhHu8mSc4I8w0TgH7sT5h+cE74t/EZ938sbds3EaCxETMIb0/VYdamoDNvnVnmV 9UYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=AD/h4rWspWWAmkvrf4jHk8krx+htmE005Yh9cR4Hyx8=; b=g149VVy2moHj9WDiP/93Ib1CGMbp7uYK43ugkwynGykvjhX+QeD7lrxrRLHsSWk3yn j8F1S4Pa5IgLSz/qvLYWON5pCtYQ6nty7KICA6Mk9fMwUc495x5z6Grz/lT5yKz8q+y8 S6x614y0I/CRY+CLLlSAoydw/+lg/jsQu7bOO1QYMNXPYYaswGE2XZlo5AXrAB8Y57BL SA36BbvhqOzYWszDaUNGKYwVQZFhGn5w/TGtkdc+wmdEC/t89g8l1IZ17GFnpunlcWVt 1gRHIcWjCfDH4j8S7P0PJCD2oI7dLb/VlqNP5AGPJDkV6GeQyjKVdRyFaPlohrdb98fD B67Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ha25si959914ejb.628.2020.07.22.18.14.41; Wed, 22 Jul 2020 18:15:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387678AbgGWBKp (ORCPT + 99 others); Wed, 22 Jul 2020 21:10:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387510AbgGWBKp (ORCPT ); Wed, 22 Jul 2020 21:10:45 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DB64C0619DC; Wed, 22 Jul 2020 18:10:45 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6A4A1126B5365; Wed, 22 Jul 2020 17:53:59 -0700 (PDT) Date: Wed, 22 Jul 2020 18:10:43 -0700 (PDT) Message-Id: <20200722.181043.1052337587227758653.davem@davemloft.net> To: colin.king@canonical.com Cc: snelson@pensando.io, drivers@pensando.io, kuba@kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] ionic: fix memory leak of object 'lid' From: David Miller In-Reply-To: <20200722174003.962374-1-colin.king@canonical.com> References: <20200722174003.962374-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Jul 2020 17:53:59 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Wed, 22 Jul 2020 18:40:03 +0100 > From: Colin Ian King > > Currently when netdev fails to allocate the error return path > fails to free the allocated object 'lid'. Fix this by setting > err to the return error code and jumping to a new label that > performs the kfree of lid before returning. > > Addresses-Coverity: ("Resource leak") > Fixes: 4b03b27349c0 ("ionic: get MTU from lif identity") > Signed-off-by: Colin Ian King Applied.