Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1595302129-23895-1-git-send-email-iamjoonsoo.kim@lge.com>
 <20200721120533.GD15516@casper.infradead.org> <4c484ce0-cfed-0c50-7a20-d1474ce9afee@suse.cz>
In-Reply-To: <4c484ce0-cfed-0c50-7a20-d1474ce9afee@suse.cz>
From:   Joonsoo Kim <js1304@gmail.com>
Date:   Thu, 23 Jul 2020 10:38:16 +0900
Message-ID: <CAAmzW4NZ3aG6ZOJ1oFxHrB9AK01=5Kt0LsAw3HT14g9L3yyxzQ@mail.gmail.com>
Subject: Re: [PATCH] mm/page_alloc: fix memalloc_nocma_{save/restore} APIs
To:     Vlastimil Babka <vbabka@suse.cz>
Cc:     Matthew Wilcox <willy@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>, kernel-team@lge.com,
        Christoph Hellwig <hch@infradead.org>,
        Roman Gushchin <guro@fb.com>,
        Mike Kravetz <mike.kravetz@oracle.com>,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        Michal Hocko <mhocko@suse.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@linux.ibm.com>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

2020=EB=85=84 7=EC=9B=94 21=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 9:39, V=
lastimil Babka <vbabka@suse.cz>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> On 7/21/20 2:05 PM, Matthew Wilcox wrote:
> > On Tue, Jul 21, 2020 at 12:28:49PM +0900, js1304@gmail.com wrote:
> >> +static inline unsigned int current_alloc_flags(gfp_t gfp_mask,
> >> +                                    unsigned int alloc_flags)
> >> +{
> >> +#ifdef CONFIG_CMA
> >> +    unsigned int pflags =3D current->flags;
> >> +
> >> +    if (!(pflags & PF_MEMALLOC_NOCMA) &&
> >> +            gfp_migratetype(gfp_mask) =3D=3D MIGRATE_MOVABLE)
> >> +            alloc_flags |=3D ALLOC_CMA;
> >
> > Please don't indent by one tab when splitting a line because it looks l=
ike
> > the second line and third line are part of the same block.  Either do
> > this:
> >
> >       if (!(pflags & PF_MEMALLOC_NOCMA) &&
> >           gfp_migratetype(gfp_mask) =3D=3D MIGRATE_MOVABLE)
> >               alloc_flags |=3D ALLOC_CMA;
> >
> > or this:
> >       if (!(pflags & PF_MEMALLOC_NOCMA) &&
> >                       gfp_migratetype(gfp_mask) =3D=3D MIGRATE_MOVABLE)
> >               alloc_flags |=3D ALLOC_CMA;
>
> Ah, good point.

Will change it.

Thanks.