From: Ingo Oeser <ioe-lkml@rameria.de>
To: Andi Kleen <ak@suse.de>
Subject: Re: [RFC PATCH 25/35] Add Xen time abstractions
Date: Wed, 10 May 2006 01:03:53 +0200
User-Agent: KMail/1.9.1
Cc: virtualization@lists.osdl.org, Chris Wright <chrisw@sous-sol.org>,
       linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com,
       Ian Pratt <ian.pratt@xensource.com>
References: <20060509084945.373541000@sous-sol.org> <20060509085157.908244000@sous-sol.org> <200605092350.03886.ak@suse.de>
In-Reply-To: <200605092350.03886.ak@suse.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200605100103.54875.ioe-lkml@rameria.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1208
Lines: 32

Hi Andi,

On Tuesday, 9. May 2006 23:50, Andi Kleen wrote:
> On Tuesday 09 May 2006 09:00, Chris Wright wrote:
> > Add support for Xen time abstractions. To avoid expensive traps into
> > the hypervisor, the passage of time is extrapolated from the local TSC
> > and a set of timestamps and scaling factors exported to the guest via
> > shared memory. Xen also provides a periodic interrupt facility which
> > is used to drive updates of xtime and jiffies, and perform the usual
> > process accounting and profiling.
> 
> There is far too much code duplication in there. I think you need to
> refactor the main time.c a bit first and strip that down.
> 
> Also you can drop all the __x86_64__ support for now.

Isn't time and timer handling a moving target anyway?
The refactoring will be done by the timer people in a completly different
manner anyway.

Are you sure, you want to disturb these efforts by requiring another
refactoring here?


Regards

Ingo Oeser
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/