Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 23 Jul 2020 11:01:23 +0800
From:   Yue Hu <zbestahu@gmail.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     jslaby@suse.com, linux-kernel@vger.kernel.org, huyue2@yulong.com,
        zbestahu@163.com
Subject: Re: [PATCH] sysrq: use only one slot for loglevels in key table
Message-ID: <20200723110123.000017e1.zbestahu@gmail.com>
In-Reply-To: <20200722104952.GB2827860@kroah.com>
References: <20200722092610.11504-1-zbestahu@gmail.com>
        <20200722104952.GB2827860@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 22 Jul 2020 12:49:52 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Wed, Jul 22, 2020 at 05:26:09PM +0800, Yue Hu wrote:
> > From: Yue Hu <huyue2@yulong.com>
> > 
> > Currently, sysrq_key_table[] has 10 slots for same interface to change
> > console loglevel. No specific purpose to do that. Let's use only one slot
> > to save memory space. Also, update the key2index calculation. And remove
> > needless code in help message print path to make the logic simpler.  
> 
> That sounds like a lot of different things being all done at once.  Can
> you break this up into individual patches, each only doing one type of
> thing at a time.

Should be not. The different command key(0 - 9) share same operation which is just
setting loglevel. And the code will find the operation via key2index calculation.
So one index/slot is enough to represent it. rt?

> 
> And if you are saving memory, please show how much you really are
> saving.

The key table is consuming global memory, decrease the array size should be more
better. It will save 9 slots space. The memory saving is 72 bytes via
sizeof(sysrq_key_table) tested under arm64.

> 
> thanks,
> 
> greg k-h