Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1003611ybh; Wed, 22 Jul 2020 20:09:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwADv7tcHU1HXhTHf0BJHGwGNtTEH8adtEEnMWBu99qqPsCZzWPIS2PHU1Im+h5qhGWEhki X-Received: by 2002:a17:907:94cc:: with SMTP id dn12mr2347654ejc.223.1595473795009; Wed, 22 Jul 2020 20:09:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595473795; cv=none; d=google.com; s=arc-20160816; b=zcya6QUiaJL2P9ob6kRhgbqwvMrAvz0gMm2e9ehDnDukrjpAshS8tbfp+W2cVQhYWz sZnIvtytoKPmJpyCqjmQk0ALbAPXu/rb+Id8UAWK4kcWIf+z5ayteR/mSMsFitP20NYu LLOEbnTudDRg5KHFlTQkxU3mkyuOR2y25BaCWh+7BHYnPSNw4L+4ipzbYXGNT2kfDrBc KfljJ/naBdLhhlZqeicATokLGyMIkNng22MfXNseOjWUmUB+Ntvu1CgoFrObQKUuBKna O3qW/+ANBkFwH9HzDSzP7aRYla0t5LBce9E+8hYhc45fvlCfezZN77jC93cphgbhxGlf 9RLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=16Npafa8/2XO3MYTIYsg9Ur1SGjt/GWTdMNHVRgNEFI=; b=fbUZdk3JVcW/mr/QQzgHvpSMkpDBl0E1WZnPDBoG6Fi/P0JzyB26LzbSRQYWuEO0sL X4Yl6CdLqqSqZNsAreuwBhZgyijahL5BZPox5IZulqnxMD3prKh1xAPElLqFMUfZ0Jwi ID67fc0oW3fJ/4Ci6X9gTrw2WlmV/Hkl3fj8mOOh6PzGpBxNKhBHTNb/66PWbl5dx4hu 9icgisfhMPzMmI+DzzpHsa3/gjV0Dpo5+xV+HLhDO+9O+CkgiuyK9KX9zZL4jPZ/Czq3 5opJURilGatVWvmivam9slBPuSOXUUx/QT80OBbJNt2zKJ6XjCSdCMZ8Le/uU6Yvje4o 5yKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e6si1274320ejx.444.2020.07.22.20.09.32; Wed, 22 Jul 2020 20:09:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387528AbgGWDJI (ORCPT + 99 others); Wed, 22 Jul 2020 23:09:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733174AbgGWDJI (ORCPT ); Wed, 22 Jul 2020 23:09:08 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 43DA2C0619DC; Wed, 22 Jul 2020 20:09:08 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E46C4126C0500; Wed, 22 Jul 2020 19:52:20 -0700 (PDT) Date: Wed, 22 Jul 2020 20:09:02 -0700 (PDT) Message-Id: <20200722.200902.2279841709265985191.davem@davemloft.net> To: navid.emamdoost@gmail.com Cc: vishal@chelsio.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, emamd001@umn.edu Subject: Re: [PATCH v3] cxgb4: add missing release on skb in uld_send() From: David Miller In-Reply-To: <20200723025841.22535-1-navid.emamdoost@gmail.com> References: <20200722.181436.414462601873878102.davem@davemloft.net> <20200723025841.22535-1-navid.emamdoost@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Jul 2020 19:52:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost Date: Wed, 22 Jul 2020 21:58:39 -0500 > In the implementation of uld_send(), the skb is consumed on all > execution paths except one. Release skb when returning NET_XMIT_DROP. > > Signed-off-by: Navid Emamdoost Applied, thank you.