Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Evgeny Novikov <novikov@ispras.ru>
Envelope-From: eugenenovikov@yandex.ru
To:     Alan Stern <stern@rowland.harvard.edu>
Cc:     Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Kees Cook <keescook@chromium.org>,
        Arnd Bergmann <arnd@arndb.de>,
        Corentin Labbe <clabbe@baylibre.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ldv-project@linuxtesting.org" <ldv-project@linuxtesting.org>
In-Reply-To: <20200723010055.GA1333715@rowland.harvard.edu>
References: <20200721201558.20069-1-novikov@ispras.ru>
         <20200722141741.GA1310843@rowland.harvard.edu>
         <2097231595446720@mail.yandex.ru> <20200723010055.GA1333715@rowland.harvard.edu>
Subject: Re: [PATCH] usb: gadget: net2280: fix memory leak on probe error handling paths
MIME-Version: 1.0
Date:   Thu, 23 Jul 2020 11:50:52 +0300
Message-Id: <1903061595494082@mail.yandex.ru>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=utf-8
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

23.07.2020, 04:00, "Alan Stern" <stern@rowland.harvard.edu>:
> On Wed, Jul 22, 2020 at 10:56:09PM +0300, Evgeny Novikov wrote:
>>  Hi Alan,
>>
>>  I have neither an appropriate hardware nor an experience to deal with
>>  issues that you mentioned. Our framework does not allow to detect them
>>  as well at the moment. At last, it seems that rather many drivers can
>>  suffer from these issues. So, it would be much better if somebody else
>>  will suggest necessary fixes and test them carefully.
>
> Heh... Working from home, I no longer have access to the appropriate
> hardware either. But at least I do have the necessary experience. :-)
>
>>  BTW, you have already discussed the race within net2280_remove() with
>>  my colleague about 3 years ago. But you did not achieve a consensus at
>>  that time and no fixes were made after all.
>
> I don't recall that. Do you have a pointer to the email thread in the
> archives?
https://lkml.org/lkml/2017/8/16/345 - this is the top message of that thread.

Evgeny
>>  Anyway, one can consider both issues independently on the one fixed by
>>  the patch.
>
> Yes. I'll write and submit a series of patches.
>
> Alan Stern