Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1172972ybh; Thu, 23 Jul 2020 02:14:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwq7mpmSopUyTsUTFiXLMr4Rt+iMVXu3LJs3QNK4oQC0yFRnhZJmAHv5lmywJ2gj/OzLvOL X-Received: by 2002:a17:906:ef2:: with SMTP id x18mr3320153eji.547.1595495649591; Thu, 23 Jul 2020 02:14:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595495649; cv=none; d=google.com; s=arc-20160816; b=ZBQnXJpKEM+IsNAeYdyqMn6FCA1lEHU2U8thR+6ZuSZ2cTlgOUGxcXIOBDgHsnr7CD a1wG45xR5bdGnnzxJT7hC84IPV/pvv4q2haoZhhfu13/fea7ZmNQN3QvwwM9pgNl8It8 by2gRLxnYxeTlGVvud8zZufEpQ4wXHmKfrYZA24OPAKEtxPRjd0krGfoQZRXiZvUsLCf bx0NiCCAW0SoY3ttKIi3DKrBNOjKd8TTJnEmyvM2VihwOhwu1bxQCV3Oh0uY+oLGrlCC jKnChleXYDgmdwsnWRJ1PTmUUPdMVKcswBcpnxDb9VVYHjAnZjZ+knP8rgHFC06+inCM 08Nw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=RSy4LtbaD8levFOBIayUOWSmIYzMSd7fCPXVTaSTU+s=; b=w9FXQi0JaKZpZhtCkZz88762p9mS+sOAcRPwdbS5k1yVb6UJAI7vjylQOctKb4X69q Lx4cZq+Lq5S4EitbPDGUuhPYUpAhQWsbkzS7qXM/cg/oUjsRhNEsyhcFC43g9IfkgrOa rC69P8TOvm1mwSiLabTOs5S1uOcHYoELqSRGanmD3uwpZZkACxtyU9QDD416ScykvHCe bWYwUNFBeoF66LjfolJ7U6vDrggR9zp4MDi1fMlTzjQLxIjJo7FbgYGM5t9Tzl/h+Zis lzseXhU1bfLkJBlX470olqCFqZFB/jNWO4EDqXh/1TX+EO4ddHbipyO6I4Zp91dpYhmY JBaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GmQUEr4+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si1549512eds.105.2020.07.23.02.13.46; Thu, 23 Jul 2020 02:14:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GmQUEr4+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728236AbgGWJNK (ORCPT + 99 others); Thu, 23 Jul 2020 05:13:10 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:20997 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725984AbgGWJNK (ORCPT ); Thu, 23 Jul 2020 05:13:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595495589; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=RSy4LtbaD8levFOBIayUOWSmIYzMSd7fCPXVTaSTU+s=; b=GmQUEr4+dQja6pz2mgqL8Ngh079n357xDRIRI2dIEeP8aysYjaMcZDQ093LOyPeL9ur5w9 eNd4DErXvaj4qua6MQI4xKrO7aViGQLUl5H7dJ06i1CkjAkjrxAc4XgTTWW/kOavIKBBan mONcz9PQUaOk+93Xppx3ucVn9sYfzWM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-149-2gLebz6nP6-9gOiGYakW6w-1; Thu, 23 Jul 2020 05:13:04 -0400 X-MC-Unique: 2gLebz6nP6-9gOiGYakW6w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6809691271; Thu, 23 Jul 2020 09:13:03 +0000 (UTC) Received: from jason-ThinkPad-X1-Carbon-6th.redhat.com (ovpn-13-141.pek2.redhat.com [10.72.13.141]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4D44870596; Thu, 23 Jul 2020 09:12:58 +0000 (UTC) From: Jason Wang To: mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Cc: Zhu Lingshan Subject: [PATCH 1/2] vdpa: ifcvf: return err when fail to request config irq Date: Thu, 23 Jul 2020 17:12:53 +0800 Message-Id: <20200723091254.20617-1-jasowang@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We ignore the err of requesting config interrupt, fix this. Fixes: e7991f376a4d ("ifcvf: implement config interrupt in IFCVF") Cc: Zhu Lingshan Signed-off-by: Jason Wang --- drivers/vdpa/ifcvf/ifcvf_main.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c index f5a60c14b979..ae7110955a44 100644 --- a/drivers/vdpa/ifcvf/ifcvf_main.c +++ b/drivers/vdpa/ifcvf/ifcvf_main.c @@ -76,6 +76,10 @@ static int ifcvf_request_irq(struct ifcvf_adapter *adapter) ret = devm_request_irq(&pdev->dev, irq, ifcvf_config_changed, 0, vf->config_msix_name, vf); + if (ret) { + IFCVF_ERR(pdev, "Failed to request config irq\n"); + return ret; + } for (i = 0; i < IFCVF_MAX_QUEUE_PAIRS * 2; i++) { snprintf(vf->vring[i].msix_name, 256, "ifcvf[%s]-%d\n", -- 2.20.1