Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1192089ybh; Thu, 23 Jul 2020 02:48:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwT7IOmVg2THpkVhadKPePTOi3qsr/RPwGDT8Ya/fFcO5xKiGrNv8j3diapGXc6vXfB4Szm X-Received: by 2002:a17:906:ce43:: with SMTP id se3mr3432762ejb.543.1595497728522; Thu, 23 Jul 2020 02:48:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595497728; cv=none; d=google.com; s=arc-20160816; b=hMLCM6ebd3qF9vyS2M2izDmlp4jYpAHVluBT/qFvpjhH9xw/VkCTRdzSSKpluItjDg qkA/0lJd5epXf6rPLQBOBNsemrZuKLpnQTgp2ERwtrPMFgDL1R+6o7VY2b6jHjbcmkVH yIqAWS9jKaCZA1uxw9/oOUPl9I3AOBYkh1FdsAxRGglIQQMlebz4FwZlwv5WPMAKyoG6 JDrMZdVgNEMXubIRHhlI79dXEBzMvwFcZA/xKH8jMYLkQcaWQUBw3mYd3eOlp7u8rfuK OyBKzfLiNucmfWYEgaULuYiRZzYMjj0EDp2+E97lRj1kE+fBiAb0fqTbPvOiQ889locP duvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:date:message-id:from :references:cc:to:subject; bh=D+azICLe9RqRLHYJqYwRt2cLqPwDNRUosj5+g2rMbHo=; b=YlcVkSvHKXhRVc8gwIxz2cnBB6sCfU85mro+EiQJK8pvedw2EbLMqb/RYC+/nGF+9p vzpcIAMlsprsHqiNVp9roghHBpfHwLVR1KDZEtdjkXmd4Bm+/KxUXs5039lGYcW764lB bpGwUXlhqMzP8nnKnnbzRBu1YqY/nC2H1JyLtqvDKHbhw7lM9HSCKrcTL2rNgPpQswuq eyvG8dNqLv7r/Z5AkOWS8GR7hMMYjgAVFlorsnRAuJLuQyG9WGOZwOQjU33Iuixq0clP G+XlRjx6AGnk4TUmRRB+VZ1wDmVDoLkhQ4HFKdaLOh8Lsx2UftgioEIb9oc4xHegY80X 1jGw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi20si1462701ejb.365.2020.07.23.02.48.25; Thu, 23 Jul 2020 02:48:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728001AbgGWJsL (ORCPT + 99 others); Thu, 23 Jul 2020 05:48:11 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:11995 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726127AbgGWJsL (ORCPT ); Thu, 23 Jul 2020 05:48:11 -0400 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 06N9XWE8045943; Thu, 23 Jul 2020 05:47:55 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 32e1yc0v15-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jul 2020 05:47:55 -0400 Received: from m0098409.ppops.net (m0098409.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 06N9XwQK047495; Thu, 23 Jul 2020 05:47:55 -0400 Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0a-001b2d01.pphosted.com with ESMTP id 32e1yc0v0c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jul 2020 05:47:55 -0400 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 06N9fL8G013581; Thu, 23 Jul 2020 09:47:52 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma06fra.de.ibm.com with ESMTP id 32brbgu5q0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Jul 2020 09:47:52 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 06N9loTk29360560 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Jul 2020 09:47:50 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0E8FF52052; Thu, 23 Jul 2020 09:47:50 +0000 (GMT) Received: from [9.145.184.33] (unknown [9.145.184.33]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id A543052057; Thu, 23 Jul 2020 09:47:49 +0000 (GMT) Subject: Re: [PATCH V6] GCOV: Add config to check the preqequisites situation To: Cixi Geng , Greg KH , jslaby@suse.com, linux-serial@vger.kernel.org, "linux-kernel@vger.kernel.org" Cc: Cixi Geng1 , Orson Zhai , zhang.lyra@gmail.com References: <20200618100852.13715-1-gengcixi@gmail.com> <2fae67c7637f4e978cb54c3b96090788@BJMBX01.spreadtrum.com> From: Peter Oberparleiter Message-ID: Date: Thu, 23 Jul 2020 11:47:51 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235,18.0.687 definitions=2020-07-23_03:2020-07-22,2020-07-23 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 suspectscore=1 bulkscore=0 adultscore=0 clxscore=1011 priorityscore=1501 mlxscore=0 mlxlogscore=999 phishscore=0 impostorscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007230072 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.07.2020 14:38, Cixi Geng wrote: > Hi All: > Does this patch need more modification? Yes. As it is now there's still a prompt for the prereq symbol. There should be no prompt for this symbol in the config dialog. [...] >> diff --git a/kernel/gcov/Kconfig b/kernel/gcov/Kconfig >> index 3941a9c48f83..f415c4aaf0ab 100644 >> --- a/kernel/gcov/Kconfig >> +++ b/kernel/gcov/Kconfig >> @@ -51,6 +51,16 @@ config GCOV_PROFILE_ALL >> larger and run slower. Also be sure to exclude files from profiling >> which are not linked to the kernel image to prevent linker errors. >> >> +config GCOV_PROFILE_PREREQS >> + bool "Profile Kernel for prereqs" >> + default y if GCOV_KERNEL && !COMPILE_TEST >> + help >> + This options activates profiling for the specified kernel modules. >> + >> + When some modules need Gcov data, enable this config, then configure >> + with gcov on the corresponding modules,The directories or files of >> + these modules will be added profiling flags after kernel compile. >> + Replace the portion above with these lines: config GCOV_PROFILE_PREREQS def_bool y if GCOV_KERNEL && !COMPILE_TEST -- Peter Oberparleiter Linux on Z Development - IBM Germany