Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1200903ybh; Thu, 23 Jul 2020 03:03:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwSwPO/rY7VUvt0l/ae/LszhK0RW9DaOVDmir6InMl15PFTJ9oIHkNgce4c4oeux9J+4aFb X-Received: by 2002:a17:906:40d6:: with SMTP id a22mr3716022ejk.133.1595498621341; Thu, 23 Jul 2020 03:03:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595498621; cv=none; d=google.com; s=arc-20160816; b=kAaTDoBEZWwXJvZ8lgDldqigndj12y3O8b9esDo4XfyPDIJw1iE/yro12eKbvhDYFh jglwyunuh8Pq7Kmqy+qfc/BmVEPVXNlvpN9878DRcTb+TtBWKjvSbWnbr1VmZUhHwfEB 8Q7y7QS6+0C3qEvpBEqxjoQ3pL3MWv9sghOVRpNDxy6cDonUdxTfzriLho28g+nTpuwW HUbPeK8KJnHjp5k3W1GZ3e87fVdeGa1Sddi3HIHXRD43NNXy1sLklpZCRBfol4HqkrlA /85kK6+fytvb2sPQ07KiqDCcutG2L+pFs6f1rha5cOlNbz4jdIE3iBRDjrSUk2tZI+k3 npUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ymebtG2Uo5xLDTvFB71RCBsokbXw8p72LY+WLQ5n6wU=; b=DIvxhVLMNbcPDLLjTJjBACXOdU56g6DRSysUBjmgGEnQb2/gzBY7Rv8e8PGV7K+S11 gtVRocx5uC2jyvCl5l1xm55iqyzdO518iF8hdmnAo/mbU9hXYJdBVDkMRtf9MMkf3tYV WP0pb+q3C2pi2Ks/1IEa5x85RpKFiZPeE3SCxrq7JaQmfRo8fpgQQdkQEmDKzza3cvzn xnBwKYGEF00Y9C8lJcoObWiF1C6EOTCIT22i2uGGUYKT4FiShW53i8djqqxrmaVjlVyN 18ptcA5cCy6hsBoSXv/BQJQEMP1oCf/u8OlOj8IOuHN+Y+k0JuIGRyAUzoDg+iZpMtkf ImyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q17si1732938eja.355.2020.07.23.03.03.17; Thu, 23 Jul 2020 03:03:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728246AbgGWKDI (ORCPT + 99 others); Thu, 23 Jul 2020 06:03:08 -0400 Received: from foss.arm.com ([217.140.110.172]:42934 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726982AbgGWKDI (ORCPT ); Thu, 23 Jul 2020 06:03:08 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4C57ED6E; Thu, 23 Jul 2020 03:03:07 -0700 (PDT) Received: from e121166-lin.cambridge.arm.com (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D527B3F66F; Thu, 23 Jul 2020 03:03:05 -0700 (PDT) Date: Thu, 23 Jul 2020 11:02:58 +0100 From: Lorenzo Pieralisi To: Kishon Vijay Abraham I Cc: Tom Joseph , Bjorn Helgaas , Rob Herring , Arnd Bergmann , Greg Kroah-Hartman , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 00/15] Add PCIe support to TI's J721E SoC Message-ID: <20200723100258.GA7195@e121166-lin.cambridge.arm.com> References: <20200722110317.4744-1-kishon@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200722110317.4744-1-kishon@ti.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 22, 2020 at 04:33:02PM +0530, Kishon Vijay Abraham I wrote: > TI's J721E SoC uses Cadence PCIe core to implement both RC mode > and EP mode. > > The high level features are: > *) Supports Legacy, MSI and MSI-X interrupt > *) Supports upto GEN4 speed mode > *) Supports SR-IOV > *) Supports multiple physical function > *) Ability to route all transactions via SMMU > > This patch series > *) Add support in Cadence PCIe core to be used for TI's J721E SoC > *) Add a driver for J721E PCIe wrapper > > v1 of the series can be found @ [1] > v2 of the series can be found @ [2] > v3 of the series can be found @ [5] > v4 of the series can be found @ [6] > v5 of the series can be found @ [7] > v6 of the series can be found @ [8] > v7 of the series can be found @ [9] > > Changes from v7: > 1) Replaced WARN with pr_warn > 2) Included support for "dma-ranges" property patch in this series [10] > > Changes from v6: > 1) Fixed bot found errors running 'make dt_binding_check' > > Changes from v5: > 1) Added Reviewed-by: for PATCH #6 > 2) Protect writes to PCI_STATUS with spin_lock during raising interrupts > in EP mode to reduce the time between read and write of RMW. > > Changes from v4: > 1) Added Reviewed-by: & Acked-by: tags from RobH > 2) Removed un-used accessors for pcie-cadence.h and removed having ops > for read/write accessors > 3) Updated cdns,cdns-pcie-host.yaml to remove "mem" from reg > > Changes from v3: > 1) Changed the order of files in MAINTAINTERS file to fix Joe's comments > 2) Fixed indentation and added Reviewed-by: Rob Herring > 3) Cleaned up computing msix_tbl > 4) Fixed RobH's comment on J721E driver > > Changes from v2: > 1) Converting Cadence binding to YAML schema was done as a > separate series [3] & [4]. [3] is merged and [4] is > pending. > 2) Included MSI-X support in this series > 3) Added link down interrupt handling (only error message) > 4) Rebased to latest 5.7-rc1 > 5) Adapted TI J721E binding to [3] & [4] > > Changes from v1: > 1) Added DT schemas cdns-pcie-host.yaml, cdns-pcie-ep.yaml and > cdns-pcie.yaml for Cadence PCIe core and included it in > TI's PCIe DT schema. > 2) Added cpu_addr_fixup() for Cadence Platform driver. > 3) Fixed subject/description/renamed functions as commented by > Andrew Murray. > > [1] -> http://lore.kernel.org/r/20191209092147.22901-1-kishon@ti.com > [2] -> http://lore.kernel.org/r/20200106102058.19183-1-kishon@ti.com > [3] -> http://lore.kernel.org/r/20200305103017.16706-1-kishon@ti.com > [4] -> http://lore.kernel.org/r/20200417114322.31111-1-kishon@ti.com > [5] -> http://lore.kernel.org/r/20200417125753.13021-1-kishon@ti.com > [6] -> http://lore.kernel.org/r/20200506151429.12255-1-kishon@ti.com > [7] -> http://lore.kernel.org/r/20200522033631.32574-1-kishon@ti.com > [8] -> http://lore.kernel.org/r/20200708093018.28474-1-kishon@ti.com > [9] -> http://lore.kernel.org/r/20200713110141.13156-1-kishon@ti.com > [10] -> http://lore.kernel.org/r/20200521080153.5902-1-kishon@ti.com > > Alan Douglas (1): > PCI: cadence: Add MSI-X support to Endpoint driver > > Kishon Vijay Abraham I (14): > PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" > property > PCI: cadence: Fix cdns_pcie_{host|ep}_setup() error path > linux/kernel.h: Add PTR_ALIGN_DOWN macro > PCI: cadence: Convert all r/w accessors to perform only 32-bit > accesses > PCI: cadence: Add support to start link and verify link status > PCI: cadence: Allow pci_host_bridge to have custom pci_ops > dt-bindings: PCI: cadence: Remove "mem" from reg binding > PCI: cadence: Add new *ops* for CPU addr fixup > PCI: cadence: Fix updating Vendor ID and Subsystem Vendor ID register > dt-bindings: PCI: Add host mode dt-bindings for TI's J721E SoC > dt-bindings: PCI: Add EP mode dt-bindings for TI's J721E SoC > PCI: j721e: Add TI J721E PCIe driver > misc: pci_endpoint_test: Add J721E in pci_device_id table > MAINTAINERS: Add Kishon Vijay Abraham I for TI J721E SoC PCIe > > .../bindings/pci/cdns,cdns-pcie-host.yaml | 8 +- > .../bindings/pci/ti,j721e-pci-ep.yaml | 94 ++++ > .../bindings/pci/ti,j721e-pci-host.yaml | 113 ++++ > MAINTAINERS | 4 +- > drivers/misc/pci_endpoint_test.c | 9 + > drivers/pci/controller/cadence/Kconfig | 23 + > drivers/pci/controller/cadence/Makefile | 1 + > drivers/pci/controller/cadence/pci-j721e.c | 493 ++++++++++++++++++ > .../pci/controller/cadence/pcie-cadence-ep.c | 129 ++++- > .../controller/cadence/pcie-cadence-host.c | 310 +++++++++-- > .../controller/cadence/pcie-cadence-plat.c | 13 + > drivers/pci/controller/cadence/pcie-cadence.c | 8 +- > drivers/pci/controller/cadence/pcie-cadence.h | 161 +++++- > include/linux/kernel.h | 1 + > 14 files changed, 1297 insertions(+), 70 deletions(-) > create mode 100644 Documentation/devicetree/bindings/pci/ti,j721e-pci-ep.yaml > create mode 100644 Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml > create mode 100644 drivers/pci/controller/cadence/pci-j721e.c Applied to pci/cadence for v5.9, thanks ! Lorenzo