Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] scripts/gdb: fix lx-symbols 'gdb.error' while loading
 modules
To:     Stefano Garzarella <sgarzare@redhat.com>,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Kieran Bingham <kbingham@kernel.org>
References: <20200722102239.313231-1-sgarzare@redhat.com>
From:   Jan Kiszka <jan.kiszka@siemens.com>
Message-ID: <418f0953-1815-1844-e3f5-a11f2a5eaf33@siemens.com>
Date:   Thu, 23 Jul 2020 12:25:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20200722102239.313231-1-sgarzare@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 22.07.20 12:22, Stefano Garzarella wrote:
> Commit ed66f991bb19 ("module: Refactor section attr into bin
> attribute") removed the 'name' field from 'struct module_sect_attr'
> triggering the following error when invoking lx-symbols:
> 
>    (gdb) lx-symbols
>    loading vmlinux
>    scanning for modules in linux/build
>    loading @0xffffffffc014f000: linux/build/drivers/net/tun.ko
>    Python Exception <class 'gdb.error'> There is no member named name.:
>    Error occurred in Python: There is no member named name.
> 
> This patch fixes the issue taking the module name from the 'struct
> attribute'.
> 
> Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>   scripts/gdb/linux/symbols.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
> index be984aa29b75..1be9763cf8bb 100644
> --- a/scripts/gdb/linux/symbols.py
> +++ b/scripts/gdb/linux/symbols.py
> @@ -96,7 +96,7 @@ lx-symbols command."""
>               return ""
>           attrs = sect_attrs['attrs']
>           section_name_to_address = {
> -            attrs[n]['name'].string(): attrs[n]['address']
> +            attrs[n]['battr']['attr']['name'].string(): attrs[n]['address']
>               for n in range(int(sect_attrs['nsections']))}
>           args = []
>           for section_name in [".data", ".data..read_mostly", ".rodata", ".bss",
> 

Reviewed-by: Jan Kiszka <jan.kiszka@siemens.com>

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux