Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1249479ybh; Thu, 23 Jul 2020 04:21:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJi6TcqiAA2Bmevd86UU/ElAYktlopYZb1hYilLFo9TPLGDeiQyXYi+KSYHwEEH6zrItC0 X-Received: by 2002:a05:6402:b72:: with SMTP id cb18mr3559635edb.352.1595503313761; Thu, 23 Jul 2020 04:21:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595503313; cv=none; d=google.com; s=arc-20160816; b=h8lPuwqO02CH5zucegMs276RDhEUnNoPw/lC87bWblXD/GZ0iZrYsCcwpUsuhtSeUv 4PS0h0lSCkbUTShgIePfBAW6WDmLu3pr0vFC5e539p2TjXGv0D15Q6nG64vYxVF2xl/F Rh11nfVGR1z4bzHVjyPGB8YsMf5vGTQdeL6a3XLST6kXYuzlMqyUacSrdWXfoMqJJjxR CcMTsYMtvlnsEhm7MxFBT2dknj+oSL/ZPqPw5ZhZSQc7s9fZs50MdZLwieTkzmp7rSRH Nb00Ymdcyt48xSnEpBDFryXbNTYH/M+cibsE310Za0c7Z8wOwc3CIAe+9Sp5TPNao8Ys 7HhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=FIObSboawIM9xhbcK9A05HrLtSU4EaR2U/qSYVOTD+g=; b=qjUf2+vXy2tseUOIWvRlpLaNMgvHdmVbZNKX/r+TI+b///gU1zINvFP6pMFOW02n3i R82DKZcQN6Qr8R7AOJ4cOFLmb3Eq2G6rgHOBKug7hQXbRjDIo+J9RBbYfr2qd36C50V4 hzhLwVmnXKMqRNb4mUrBrBnn6VMmyJRIOt/0MyXDeqesM/QQHHX6qUuCI//vLmoyGEfj b9fxft7DvNLC3nxkEI/+3w7jS7qsiN7Wy0cpKQGr1t6DH0+nygyRSEIHKEOeGtKoNoPJ ECsZ13JFd5V3PyNI+MjsW82JZMeYnvYewa6QMumQIvM93nX5SLZ8qIWHj23TCM0plnT3 79WQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZQmYhHIq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a3si1694632ejc.288.2020.07.23.04.21.29; Thu, 23 Jul 2020 04:21:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ZQmYhHIq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728199AbgGWLSY (ORCPT + 99 others); Thu, 23 Jul 2020 07:18:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:56910 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726867AbgGWLSX (ORCPT ); Thu, 23 Jul 2020 07:18:23 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C18C4206F4; Thu, 23 Jul 2020 11:18:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595503103; bh=7yYsCXQZddIcngHN79CYvQZyJ/SNajKQiZIuQXTYH1Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZQmYhHIqSL58pJgKhwa5wstW04qTgqgJtyLDnFIVGFQ1uqTP6sYe4eOKu32wm7drq siQxhNZni9V6jqNnBXBOom01DACzlDbehFZHfXBN4RPkt8lTAIDi1qU/u5gOqeEqOp /XIMgEkqsT+7EdbyVEZjv8meITwAiwf0o7KNgpBk= Date: Thu, 23 Jul 2020 13:18:27 +0200 From: Greg Kroah-Hartman To: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mtd: properly check all write ioctls for permissions Message-ID: <20200723111827.GA1963557@kroah.com> References: <20200716115346.GA1667288@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200716115346.GA1667288@kroah.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 16, 2020 at 01:53:46PM +0200, Greg Kroah-Hartman wrote: > When doing a "write" ioctl call, properly check that we have permissions > to do so before copying anything from userspace or anything else so we > can "fail fast". This includes also covering the MEMWRITE ioctl which > previously missed checking for this. > > Cc: Miquel Raynal > Cc: Richard Weinberger > Cc: Vignesh Raghavendra > Cc: stable > Signed-off-by: Greg Kroah-Hartman > --- > drivers/mtd/mtdchar.c | 54 +++++++++++++++++++++++++++++++++++-------- > 1 file changed, 45 insertions(+), 9 deletions(-) Any objection to this patch getting into 5.8-final? I can take this through one of my trees if you all give me an ack :) thanks, greg k-h