Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1270352ybh; Thu, 23 Jul 2020 04:53:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwjvbknIZzJui6tVBphXR1nLm7mkM/lrnQYP+GEpQ+fznT8p5unE7udEHhPOsKrBaix3NXn X-Received: by 2002:a17:906:430b:: with SMTP id j11mr3966312ejm.270.1595505199685; Thu, 23 Jul 2020 04:53:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595505199; cv=none; d=google.com; s=arc-20160816; b=q6qPUyx/+SN42Q5P9dCsWmj5DemhCBPvmvnCtVRpv/G2GZ4BbWcgEUXrsoY2I6EKH1 PZw/2eG/hXUIye8ILD/sOIB3XE7nU7/o+Zf4MhIj4rMLoU7Q0Pbkm6jYPMCKDIz5nXbc dgdudVW+DPJtBpK0cVNm9G6edJgpuoXdN09NVLp0dOrj/Xeupv/wnAqD9Y6llcLaqS4q tDgw8PvVY+ilRpOP3biILIhzcGPA7sZpQskVCE89vL77SmcEI4Jigqxf6We8Zp2yTgqJ Lwz6hd55Y8/6IdJ5a8g+srrR8PjKIdgy6qhjkoQwUcgRo3/ssSRRgwch8vY3umew1yHD Scew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:references:cc:to:from:subject :dkim-signature; bh=CIXSVu9nQP+8PDb0hzoMQSS9r8hDzc01kzYIvCbHTjQ=; b=B0tZc3DiwHwb9J3VpOoUDsdRWWcjK+rXkLu5H8UuMkOW1sfi7tT2LvnHUZyDZVTAk3 TQlg08dgCw2YGFNESC4p6wJCzdUqZUblBbagOol68Ij7SwczzolXxguF7/o7reD2CDQP zf+xVk5XdRrXUrEPYAAYlx+maJ68WMbR2iHHJuivuyIchkiYhrPPBpUmH39GerArAJHU XUcKn6+wbMhjG5FHTptqislx0UYj7gKVLeRc4wGdFki5Tku3HICT077FsVqn9NS/Bh98 FUlS04/bLc/o5o0cNoCu8m8DTLri3bvm2ou+S9+lKlNLy+FEdk8oL/KDBUYF4b/KD+Vd liwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=I9BoKGKo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e5si1904716ejb.453.2020.07.23.04.52.57; Thu, 23 Jul 2020 04:53:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=I9BoKGKo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728784AbgGWLwN (ORCPT + 99 others); Thu, 23 Jul 2020 07:52:13 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:30233 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728499AbgGWLwN (ORCPT ); Thu, 23 Jul 2020 07:52:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595505131; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CIXSVu9nQP+8PDb0hzoMQSS9r8hDzc01kzYIvCbHTjQ=; b=I9BoKGKozE/Fem5Vva5pTYcdgoDTzq5cIlIfKbyHL8i5xIyIw0CkBrfkLlY0NvqRXUsMn3 wY8yo4lSrVqnr1l+HQI03KoUcvdbuuHVRXvBJL/9juXftR9PDcFWPUpXd7/Rym2ok36tB8 pgJUnEwPoYYcs03qGlcYQoAp66+iY54= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-442-wWfQow7ePFKPEJa9Ohw43Q-1; Thu, 23 Jul 2020 07:52:06 -0400 X-MC-Unique: wWfQow7ePFKPEJa9Ohw43Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A4961009440; Thu, 23 Jul 2020 11:52:05 +0000 (UTC) Received: from [10.36.114.90] (ovpn-114-90.ams2.redhat.com [10.36.114.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id 71FFB5C1BD; Thu, 23 Jul 2020 11:52:03 +0000 (UTC) Subject: Re: [PATCH 3/3] memory: introduce an option to force onlining of hotplug memory From: David Hildenbrand To: Roger Pau Monne , linux-kernel@vger.kernel.org Cc: Boris Ostrovsky , Juergen Gross , Stefano Stabellini , Andrew Morton , xen-devel@lists.xenproject.org, linux-mm@kvack.org References: <20200723084523.42109-1-roger.pau@citrix.com> <20200723084523.42109-4-roger.pau@citrix.com> <21490d49-b2cf-a398-0609-8010bdb0b004@redhat.com> Autocrypt: addr=david@redhat.com; prefer-encrypt=mutual; keydata= mQINBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABtCREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT6JAlgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63W5Ag0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAGJAjwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat GmbH Message-ID: <18f3987f-d2ca-409b-951d-20381d96e3a8@redhat.com> Date: Thu, 23 Jul 2020 13:52:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <21490d49-b2cf-a398-0609-8010bdb0b004@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.07.20 13:37, David Hildenbrand wrote: > On 23.07.20 10:45, Roger Pau Monne wrote: >> Add an extra option to add_memory_resource that overrides the memory >> hotplug online behavior in order to force onlining of memory from >> add_memory_resource unconditionally. >> >> This is required for the Xen balloon driver, that must run the >> online page callback in order to correctly process the newly added >> memory region, note this is an unpopulated region that is used by Linux >> to either hotplug RAM or to map foreign pages from other domains, and >> hence memory hotplug when running on Xen can be used even without the >> user explicitly requesting it, as part of the normal operations of the >> OS when attempting to map memory from a different domain. >> >> Setting a different default value of memhp_default_online_type when >> attaching the balloon driver is not a robust solution, as the user (or >> distro init scripts) could still change it and thus break the Xen >> balloon driver. > > I think we discussed this a couple of times before (even triggered by my > request), and this is responsibility of user space to configure. Usually > distros have udev rules to online memory automatically. Especially, user > space should eb able to configure *how* to online memory. > > It's the admin/distro responsibility to configure this properly. In case > this doesn't happen (or as you say, users change it), bad luck. > > E.g., virtio-mem takes care to not add more memory in case it is not > getting onlined. I remember hyper-v has similar code to at least wait a > bit for memory to get onlined. > > Nacked-by: David Hildenbrand > Oh, BTW, I removed that "online" parameter in commit f29d8e9c0191a2a02500945db505e5c89159c3f4 Author: David Hildenbrand Date: Fri Dec 28 00:35:36 2018 -0800 mm/memory_hotplug: drop "online" parameter from add_memory_resource() Userspace should always be in charge of how to online memory and if memory should be onlined automatically in the kernel. Let's drop the parameter to overwrite this - XEN passes memhp_auto_online, just like add_memory(), so we can directly use that instead internally. Xen was passing "memhp_auto_online" since commit 703fc13a3f6615e29ce3eb862275d7b58a5d03ba Author: Vitaly Kuznetsov Date: Tue Mar 15 14:56:52 2016 -0700 xen_balloon: support memory auto onlining policy Add support for the newly added kernel memory auto onlining policy to Xen ballon driver. And before that I assume XEN was completely relying on udev rules to handle it. Parameter was introduced in commit 31bc3858ea3ebcc3157b3f5f0e624c5962f5a7a6 Author: Vitaly Kuznetsov Date: Tue Mar 15 14:56:48 2016 -0700 memory-hotplug: add automatic onlining policy for the newly added memory Currently, all newly added memory blocks remain in 'offline' state unless someone onlines them, some linux distributions carry special udev rules like: SUBSYSTEM=="memory", ACTION=="add", ATTR{state}=="offline", ATTR{state}="online" -- Thanks, David / dhildenb