Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964783AbWEJDbp (ORCPT ); Tue, 9 May 2006 23:31:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964784AbWEJDbp (ORCPT ); Tue, 9 May 2006 23:31:45 -0400 Received: from gateway-1237.mvista.com ([63.81.120.158]:1356 "EHLO gateway-1237.mvista.com") by vger.kernel.org with ESMTP id S964783AbWEJDbo (ORCPT ); Tue, 9 May 2006 23:31:44 -0400 Subject: Re: [BUG] mtd redboot (also gcc 4.1 warning fix) From: Daniel Walker To: Olof Johansson Cc: Matheus Izvekov , linux-kernel@vger.kernel.org In-Reply-To: <20060510032912.GC1794@lixom.net> References: <200605100256.k4A2u4FO031737@dwalker1.mvista.com> <305c16960605092014t240ece2ob620264501deaa39@mail.gmail.com> <20060510032912.GC1794@lixom.net> Content-Type: text/plain Date: Tue, 09 May 2006 20:31:40 -0700 Message-Id: <1147231901.21536.47.camel@c-67-180-134-207.hsd1.ca.comcast.net> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 902 Lines: 21 On Tue, 2006-05-09 at 22:29 -0500, Olof Johansson wrote: > On Wed, May 10, 2006 at 12:14:45AM -0300, Matheus Izvekov wrote: > > On 5/9/06, Daniel Walker wrote: > > >unsigned long may not always be 32 bits, right ? This patch fixes the > > Incorrect, its defined as 32bits for every standard C compiler > > Wrong. The only environment I'm aware of that has only P64 is Win64. > > Still, that's a bad patch, since it removes the warning without fixing > the bug. It's a valid warning, the underlying problem should be fixed > instead. It's better to keep the warning around until that's been done. I never claimed to fix it .. Daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/