Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1345958ybh;
        Thu, 23 Jul 2020 06:42:34 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzVIMIfofVqL206EEbtEVQywFpAi3eLRWbrXCNkPVaXegF41SyVeAkjRsyE10ZGxYO4X5q4
X-Received: by 2002:a17:906:c04d:: with SMTP id bm13mr4335181ejb.321.1595511754282;
        Thu, 23 Jul 2020 06:42:34 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1595511754; cv=none;
        d=google.com; s=arc-20160816;
        b=jZbqHgeceIfOrYcIpzG5VZ35WqeHWZpohmoSn+Iztd4Ng1IoAgN0IK6XvBwrIMq1Vh
         whdxvCDt3/KHX67d8iyAuTsbiDRVNKKpvYvXKLWobBBXPMy5j6sObGwRAUBMUOLlJP/2
         YypY3wfaa+ePtKgxKiwsKHz9uNnvtrJVFoBzzXwmz0OVJ6Lt1CpBLG8Z1jynb2q5zxvv
         Tky9SZkqnfsMV+ewNzIUrgKw/kmKJZ9zDuRW14CKjt7C04ZoIjYwb3m1RS+fmWSf2DBK
         gj/Y3M0EP6isWkhlf1SwjqHcWXdx4NJuR7X8MU4kWwrITDXM1a2EVHbpoXc+NmKzTsEX
         lxcQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:mime-version:message-id:date:references
         :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from;
        bh=V7OjnkZ2xJU71jNjrdw2oXGsBAeiO+oLsLemJQYKcWo=;
        b=KqaC/2flMfyGDn9mHIrSX2ZiifXXGfm63Y4OAr4PbuEMcNMkMmKkbaObx6G+2qp7RY
         eUFQocCIvWYFLPVF1JOaQTjYY1SvfS3OF9i5tyemRi6NW3ySaaCp7hN8O5GW7jsdzPAl
         knVMCIrQR2SsDLeTk725EFqz8CSrvF/L/xL1l8lCOE1Q4NQJyTQjW+Bk3Ktj7BNF96LF
         A3jLoHS7Juo9MiIQBdHx36zOJ0YvtnAJ6kLIeHAuFsd2utmsKopw+WgqDDOogpBBqbZl
         Q7bxeCM+BOSCbQd6pWDHoksaOXUsOGdN54fSW/J3iTj4pnq/gKks0SUsFAS1259FgmtD
         jtZw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linutronix.de header.s=2020 header.b=KSg83ZoQ;
       dkim=neutral (no key) header.i=@linutronix.de header.b=yJLLfTbz;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id n7si1698432edv.74.2020.07.23.06.42.11;
        Thu, 23 Jul 2020 06:42:34 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linutronix.de header.s=2020 header.b=KSg83ZoQ;
       dkim=neutral (no key) header.i=@linutronix.de header.b=yJLLfTbz;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728006AbgGWNlw (ORCPT <rfc822;peterpeng024@gmail.com>
        + 99 others); Thu, 23 Jul 2020 09:41:52 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41926 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726761AbgGWNlw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Jul 2020 09:41:52 -0400
Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4BBEAC0619DC
        for <linux-kernel@vger.kernel.org>; Thu, 23 Jul 2020 06:41:52 -0700 (PDT)
From:   Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020; t=1595511710;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=V7OjnkZ2xJU71jNjrdw2oXGsBAeiO+oLsLemJQYKcWo=;
        b=KSg83ZoQejdV8fiucONJSoBCJ1yg4LU9dUOCWzFYtxgkkqySVUgxXIYcfmK4Tiohcy4GX6
        wpsR2y+E7h1v6WtCf7Q51jT56l/ahbQ81vOs4IUnjb3edt2Qpjs37cjNhSnSONv7l2o5TW
        enG7DK81HCGGc2t+haLSJuPWFcl7OiHoAq+C9HlQ7AkfaQfWKaOxtt8A6nAHnxs76iaES1
        FylGCBgmk7bod6XMwfG453zhMF5ThhRlFY/oflsyYYsfVf6lIMgwmwXDhqRAlATlOIJyRI
        QiPsgI/aKMi2X6hg9TO4e4kJN6wMiRK2HbSkltEEigfBKdypwDuzksxj4DalEQ==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
        s=2020e; t=1595511710;
        h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
         to:to:cc:cc:mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=V7OjnkZ2xJU71jNjrdw2oXGsBAeiO+oLsLemJQYKcWo=;
        b=yJLLfTbzJaUoSb1F1OZDIW17E3bhVzZblbSPEIPFdMNvKvH9C6zhfNblmtv6PgYBqpOANv
        cT1ap1lH1D4LEDBw==
To:     qianjun.kernel@gmail.com, peterz@infradead.org, will@kernel.org,
        luto@kernel.org, urezki@gmail.com, linux-kernel@vger.kernel.org
Cc:     laoar.shao@gmail.com, jun qian <qianjun.kernel@gmail.com>
Subject: Re: [PATCH V3] Softirq:avoid large sched delay from the pending softirqs
In-Reply-To: <1595480041-10597-1-git-send-email-qianjun.kernel@gmail.com>
References: <1595480041-10597-1-git-send-email-qianjun.kernel@gmail.com>
Date:   Thu, 23 Jul 2020 15:41:50 +0200
Message-ID: <87d04mxs9t.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

qianjun.kernel@gmail.com writes:
> From: jun qian <qianjun.kernel@gmail.com>
> +		/*
> +		 * the softirq's action has been running for too much time
> +		 * so it may need to wakeup the ksoftirqd
> +		 */
> +		if (need_resched() && ktime_get() > end)
> +			break;

As per my reply on V2 this is leaking non handled pending bits. If you
do a V4, can you please use sched_clock() instead of ktime_get()?

Thanks,

        tglx