Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1410204ybh; Thu, 23 Jul 2020 08:14:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyg3kJLe11o1jB+in7jtILzH4ETd70qFFyV1dvbaNe1WvaoCZ1Kpr4e1fFzsI73uyaqCeSc X-Received: by 2002:a17:906:1e85:: with SMTP id e5mr4880467ejj.76.1595517266137; Thu, 23 Jul 2020 08:14:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595517266; cv=none; d=google.com; s=arc-20160816; b=nH3Ki4aQaaSYzIiuGR9FDJOFOtdYqMBIgqGx+Yb5gjJAlb0zR44qGprE137L/eyY8i hNwLyGcoo/zUrPIlaJbQgMzA/GntOwDkq4Z1HbwKMLJcUDvaMAezR+aq5vuUX/72Pc0H 73m7EOEBkVhW6JvQWuwY4sOmdSRaBNb8Oq8ElZBOZ3jr3dcdYWWAqjnxKYq1jqPaJ4Ew BKTVMARk4ThlcdrQoG5+jC+Smp7C8DBTAgKLKb3N00TkOZjS6/I0ntOYDaLN5N4yStow jXndKyJC82OE1WRGIRRF4Bay2gP3BUsbOjsRzHZRYMU2wVYsZC3276jKRfdGcqeFoiBM LbDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=oI0Jg9bkxCzNeVYx3z288QMCIdWb7AOLrlruM1761Rg=; b=rgSy4UEMxfFS1ARS+SHOdFueTSj+6nn80RUheK4NJIm3Nzg3sAFkxOubaC11o19sCt w2BhuscU+RK25QxfzbYlgF/CFAOSk5hJ9n8TMpOL40sBvhPlDYhreC/Zta7fdGx+Dnn5 FznAMY/Mb6fsZaWCf8zL/RqvhOPxeHwGxGDVdCecUnBcAp7WehmB32jtGRc1ric82kJa p3vy+/6gC1q4FxfsAiw4I69kn+R0QJipcsuQJ7fAbGCf7rzIOzRxa8cmYzKSbzBOpT/7 yGrMiJ6+C35SV82+nrm28p4PHEJ1dMBpw5Zu/cA7Sol76QLdclg5YL/xe5SmKiHEGUQp H62g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=njGxuA8e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qc24si20097ejb.398.2020.07.23.08.14.04; Thu, 23 Jul 2020 08:14:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=njGxuA8e; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728696AbgGWPNH (ORCPT + 99 others); Thu, 23 Jul 2020 11:13:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:49952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727885AbgGWPNH (ORCPT ); Thu, 23 Jul 2020 11:13:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 948F320771; Thu, 23 Jul 2020 15:13:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595517187; bh=bjP+t3vcFK/TJaMpjuhHN2sSEVOmcE09XJOsMG2/VCM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=njGxuA8ecQB07uRS7ajKvbbCv3NhuhB/9Uz6ECB99UCeX2eZruo77NPheI0h93WTE ZIpd5KOv+iDAJYjH4socC3yh/nET+NfUgKJb4jQdy9Y3+/PjJvDvS0hhdqIu3a+Fpi sQcBki7nbzL/qjxANeA9G1VpDAIOZns9XCk9WAsY= Date: Thu, 23 Jul 2020 17:13:10 +0200 From: Greg Kroah-Hartman To: Tomas Winkler Cc: Alexander Usyskin , linux-kernel@vger.kernel.org, "Gustavo A . R . Silva" , Arnd Bergmann Subject: Re: [char-misc-next 1/6] mei: hbm: use sizeof of variable instead of struct type Message-ID: <20200723151310.GA2809544@kroah.com> References: <20200723145927.882743-1-tomas.winkler@intel.com> <20200723145927.882743-2-tomas.winkler@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200723145927.882743-2-tomas.winkler@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 23, 2020 at 05:59:22PM +0300, Tomas Winkler wrote: > There is a possibility of bug when variable type has changed but > corresponding struct passed to the sizeof has not. > > Cc: Gustavo A. R. Silva > Signed-off-by: Tomas Winkler > --- > drivers/misc/mei/hbm.c | 74 ++++++++++++++++++------------------------ > 1 file changed, 32 insertions(+), 42 deletions(-) This doesn't apply to my tree as I've applied Gustavo's patch. Should I revert that first? thanks, greg k-h