Received: by 2002:a25:e74b:0:0:0:0:0 with SMTP id e72csp1454641ybh; Thu, 23 Jul 2020 09:14:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz26FxBAOLtuaxhjBTzAkfZBp8cmIQyQI6jtABRsC7ppheLoTATdSiAHdyKHftS4ry+i1tV X-Received: by 2002:a50:8f83:: with SMTP id y3mr4918156edy.257.1595520890798; Thu, 23 Jul 2020 09:14:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595520890; cv=none; d=google.com; s=arc-20160816; b=w/GeghxqdQCus+oSvqP15SFCuSQ4bPUag4RkUoBecCVkMNeFhakRB9jJRh/QBj7sF8 v6bX/g5dTCX5gPeah1AwbXmisSMmrozepjgsLdsKie9yjWrutj5GhZpRfIt3UbohBkaz XGDHWNUCTk3zR7swFndJ6UEGl+QjjKTIVm/zQg8MU5ARZTxJxl2NqwLGhXk8OrBojCtL 3bS5gACLRSODWYTSR9lkGF8pbt53f5ob3pQmtpXEmCVISos+O6aUbU/nHC7DAp7ALh9q lDY+UojYOQ4zJI9dNIqZI1WLEg/eKj8NNwYM6Jx9Ukdglf+Mq2GUWF2crIi08G1Gr7og tm8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=03gImqmV/5o4JWo+paLuABLNCIPvvsNpOca0cYA5j0M=; b=rsvE81SmLdJBOmEPDlIh148Nrt+hqbtxliRAVltBh6j6IXcaWOfgG+apqdgIymdJbu DvOD8qo56CudP1nF/fHf8pt/+uCLDUoNkBdrk+iCZh4423m4NtFQad2QEh1PmWQVKxky kaB1E8sLbEE2v6ZRyj8b52m/TUoBHRMxXyKEk9aDe3pD7bFF98gx9h3kFpF0eNhOndcd TPWXqVEq/+avz3WQYDVYvhCInQ3r5URMweGuti0IM6AXGsTIUyh17jzi+1iwc9wJNISB 37kB0YDgnw1YaymuSljtHKmjONyFkiVsOsR5AWjnHI9mQCGHdhVrczZF5lYDlfff9LUy lP9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id re20si2305529ejb.31.2020.07.23.09.14.28; Thu, 23 Jul 2020 09:14:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728791AbgGWQOL (ORCPT + 99 others); Thu, 23 Jul 2020 12:14:11 -0400 Received: from mga17.intel.com ([192.55.52.151]:15492 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbgGWQOK (ORCPT ); Thu, 23 Jul 2020 12:14:10 -0400 IronPort-SDR: lE4Ge1XMALuqv/iJ+Wyd6Ws2Gn98E9isY5FmyReICy4x0qxleUUXyCXU8udY5KYtNZ065ZuxuJ QXbHohQz7RhA== X-IronPort-AV: E=McAfee;i="6000,8403,9691"; a="130638072" X-IronPort-AV: E=Sophos;i="5.75,387,1589266800"; d="scan'208";a="130638072" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2020 09:14:10 -0700 IronPort-SDR: hSdGVxE6AQ8tvikdKjXnStT0/WntneULyJ9PFHgMkn6qq7qFiUZNVbSkdPUh8duuYKf4mOqT0X y6tFGrLNHSrg== X-IronPort-AV: E=Sophos;i="5.75,387,1589266800"; d="scan'208";a="488421556" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2020 09:14:10 -0700 From: ira.weiny@intel.com To: Peter Zijlstra Cc: Ira Weiny , Tony Luck , x86@kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Andy Lutomirski Subject: [PATCH] x86: Correct noinstr qualifiers Date: Thu, 23 Jul 2020 09:14:05 -0700 Message-Id: <20200723161405.852613-1-ira.weiny@intel.com> X-Mailer: git-send-email 2.28.0.rc0.12.gb6a658bd00c9 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ira Weiny The noinstr qualifier is to be specified before the return type in the same way inline is used. These 2 cases were missed by previous patches. Reviewed-by: Tony Luck Signed-off-by: Ira Weiny --- arch/x86/kernel/alternative.c | 2 +- arch/x86/kernel/cpu/mce/core.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c index 20e07feb4064..4b7b980c87df 100644 --- a/arch/x86/kernel/alternative.c +++ b/arch/x86/kernel/alternative.c @@ -1046,7 +1046,7 @@ static __always_inline int patch_cmp(const void *key, const void *elt) return 0; } -int noinstr poke_int3_handler(struct pt_regs *regs) +noinstr int poke_int3_handler(struct pt_regs *regs) { struct bp_patching_desc *desc; struct text_poke_loc *tp; diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c index 1a0139d9a34b..c5204d7bca2b 100644 --- a/arch/x86/kernel/cpu/mce/core.c +++ b/arch/x86/kernel/cpu/mce/core.c @@ -1214,7 +1214,7 @@ static void kill_me_maybe(struct callback_head *cb) * backing the user stack, tracing that reads the user stack will cause * potentially infinite recursion. */ -void noinstr do_machine_check(struct pt_regs *regs) +noinstr void do_machine_check(struct pt_regs *regs) { DECLARE_BITMAP(valid_banks, MAX_NR_BANKS); DECLARE_BITMAP(toclear, MAX_NR_BANKS); -- 2.25.1