Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750805AbWEJGlW (ORCPT ); Wed, 10 May 2006 02:41:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750822AbWEJGlW (ORCPT ); Wed, 10 May 2006 02:41:22 -0400 Received: from mta2.cl.cam.ac.uk ([128.232.0.14]:35563 "EHLO mta2.cl.cam.ac.uk") by vger.kernel.org with ESMTP id S1750805AbWEJGlV (ORCPT ); Wed, 10 May 2006 02:41:21 -0400 In-Reply-To: <20060509235122.GJ24291@moss.sous-sol.org> References: <20060509085201.446830000@sous-sol.org> <20060509235122.GJ24291@moss.sous-sol.org> Mime-Version: 1.0 (Apple Message framework v623) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: Content-Transfer-Encoding: 7bit Cc: virtualization@lists.osdl.org, linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, Herbert Xu , ian.pratt@xensource.com, netdev@vger.kernel.org From: Keir Fraser Subject: Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver. Date: Wed, 10 May 2006 07:36:57 +0100 To: Chris Wright X-Mailer: Apple Mail (2.623) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 916 Lines: 26 On 10 May 2006, at 00:51, Chris Wright wrote: > * Herbert Xu (herbert@gondor.apana.org.au) wrote: >> Chris Wright wrote: >>> >>> + netdev->features = NETIF_F_IP_CSUM; >> >> Any reason why IP_CSUM was chosen instead of HW_CSUM? Doing the latter >> would seem to be in fact easier for a virtual driver, no? > > That, I really don't know. Checksum offload was added late to the virtual transport and currently not enough info is carried to identify protocol checksum fields in arbitrary locations. When we rev the virtual interface, and include a proper checksum-offset field, we'll be able to switch to NETIF_F_HW_CSUM. -- Keir - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/